fix(migrate): don't add playwright when @playwright/test exists - #2637
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07cbdf96ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@yusuke99 Thanks! |
Part of #2037:
Summary
vp migratecurrently addsplaywrighttodevDependencieseven when@playwright/testis already declared.Since
@playwright/testalready depends on playwright, this adds a redundant direct dependency and unnecessarilypackage.jsonmodification.Ref: https://github.com/microsoft/playwright/blob/main/packages/playwright-test/package.json#L33
What's changed
Added a check that recognizes a browser provider's runtime peer when it is declared directly or available through a known package (
@playwright/test)When
@playwright/testis declared, the migrator treats the Playwright runtime as already available and skips adding a directplaywrightdependency.