Skip to content

fix(migrate): don't add playwright when @playwright/test exists - #2637

Merged
fengmk2 merged 6 commits into
voidzero-dev:mainfrom
yusuke99:fix/migrate-playwright
Sep 9, 2026
Merged

fix(migrate): don't add playwright when @playwright/test exists#2637
fengmk2 merged 6 commits into
voidzero-dev:mainfrom
yusuke99:fix/migrate-playwright

Conversation

@yusuke99

@yusuke99 yusuke99 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Part of #2037:

when @playwright/test deps exists, no need to add playwright to devDeps. npmx-dev/npmx.dev#2990 (changes)

Summary

vp migrate currently adds playwright to devDependencies even when @playwright/test is already declared.

Since @playwright/test already depends on playwright, this adds a redundant direct dependency and unnecessarily package.json modification.

Ref: https://github.com/microsoft/playwright/blob/main/packages/playwright-test/package.json#L33

What's changed

Added a check that recognizes a browser provider's runtime peer when it is declared directly or available through a known package (@playwright/test)

When @playwright/test is declared, the migrator treats the Playwright runtime as already available and skips adding a direct playwright dependency.

@socket-security

socket-security Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​playwright/​test@​1.60.010010010099100

View full report

@fengmk2 fengmk2 self-assigned this Sep 9, 2026
@yusuke99
yusuke99 requested a review from fengmk2 September 9, 2026 10:05
@fengmk2

fengmk2 commented Sep 9, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T13:51:00.634312Z 07cbdf9 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@fengmk2 fengmk2 added test: e2e Auto run e2e tests test: create-e2e Run `vp create` e2e tests labels Sep 9, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 07cbdf96ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/migration/migrator/shared.ts
@fengmk2

fengmk2 commented Sep 9, 2026

Copy link
Copy Markdown
Member

@yusuke99 Thanks!

@fengmk2
fengmk2 merged commit 31b0922 into voidzero-dev:main Sep 9, 2026
101 checks passed
@yusuke99
yusuke99 deleted the fix/migrate-playwright branch September 9, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: create-e2e Run `vp create` e2e tests test: e2e Auto run e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants