fix(select): wrap arrow-key navigation at list boundaries - #715
Open
ywenhao wants to merge 2 commits into
Open
Conversation
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
fengmk2
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The task selector opened by
vp run/vprstops at the first and last entries. Users switching fromnrexpect Up on the first task to select the last, and Down on the last task to select the first. This also makes tasks near the end of a long list quicker to reach.Refs voidzero-dev/vite-plus#2638. The implementation belongs to the shared
vt_selectcomponent in this repository.Changes
State::move_upandState::move_downover the current selectable items and keep the selected row visible.Vite+ will need to consume an updated Vite Task revision after this is merged. This does not change the separate top-level command picker opened by bare
vp.