fix(run): terminate descendants when cancelling tasks - #724
Open
danieljvdm wants to merge 3 commits into
Open
danieljvdm wants to merge 3 commits into
danieljvdm wants to merge 3 commits into
Conversation
Co-authored-by: GPT-6 Codex <codex@openai.com>
Co-authored-by: GPT-6 Codex <codex@openai.com>
Co-authored-by: GPT-6 Codex <codex@openai.com>
danieljvdm
marked this pull request as ready for review
September 15, 2026 00:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When one task fails, cancelling a sibling currently kills only its direct Unix child. A Vitest task can therefore leave its workerd runtime running after cancellation. Before #675, that orphan also held the fspy lock and prevented the outer runner from exiting; nonblocking trace collection removes that wait but does not terminate the orphan.
Give each piped or noninteractive Unix task its own process group and terminate that group on cancellation. Interactive inherited terminal tasks keep their foreground group; Ctrl-C is forwarded to isolated task groups. Windows uses the existing Job Object at cancellation time. Poll task lifetime handling alongside output draining so an inherited pipe cannot delay cancellation.
The generic fspy API gains an opt-in process-group setting and a captured child PID. Its default behavior is unchanged.