Skip to content

refactor(cache): expose remote cache settings in plan snapshots - #740

Merged
wan9chi merged 1 commit into
mainfrom
remote-cache-plan
Sep 21, 2026
Merged

wan9chi merged 1 commit into
mainfrom
remote-cache-plan

Conversation

@wan9chi

@wan9chi wan9chi commented Sep 21, 2026

Copy link
Copy Markdown
Member

Motivation

Remote cache configuration needs a place in resolved task options and execution cache metadata. Add these fields and types so their snapshot changes can be reviewed separately from configuration behavior.

Existing plan snapshots show whether each task permits remote caching and include remote_cache: null inside cache metadata. The existing plan tests exercise these initial values.

@wan9chi
wan9chi added this pull request to stack #741 September 21, 2026 10:45
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedcargo/​syn@​3.0.6100100100100100
Addedcargo/​url@​2.5.8100100100100100

View full report

@github-actions

Copy link
Copy Markdown

fspy benchmark

linux

dynamic/launch             change  -2.44%  [-17.28% .. +17.31%]  overhead  +342.81%
dynamic/access             change  -0.28%  [-16.16% .. +15.91%]  overhead   +11.73%
dynamic/access-relative    change  +0.97%  [ -7.87% .. +16.64%]  overhead   +56.91%
dynamic/access-contended   change  -4.42%  [-18.98% .. +22.22%]  overhead   +18.19%
static/launch              change  -0.81%  [-14.55% .. +15.32%]  overhead  +650.29%
static/access              change  +4.24%  [-19.08% .. +25.99%]  overhead  +937.42%
static/access-relative     change  -4.74%  [-18.76% .. +12.82%]  overhead +1499.31%
static/access-contended    change  +3.43%  [-15.53% .. +27.25%]  overhead +2828.31%

macos

dynamic/launch             change  +1.23%  [ -3.48% ..  +5.26%]  overhead  +226.43%
dynamic/access             change  -0.94%  [-10.02% ..  +6.68%]  overhead    +2.65%
dynamic/access-relative    change  +1.37%  [-10.92% .. +14.03%]  overhead  +240.12%
dynamic/access-contended   change  -0.34%  [-66.02% ..  +6.97%]  overhead    +6.20%

windows

dynamic/launch             change  +0.96%  [ -7.66% ..  +7.62%]  overhead   +25.54%
dynamic/access             change  -1.04%  [-11.46% ..  +7.91%]  overhead    +1.26%
dynamic/access-relative    change  +2.28%  [-19.83% .. +25.59%]  overhead    +3.30%
dynamic/access-contended   change  +0.11%  [-18.48% ..  +4.22%]  overhead    +3.40%

@wan9chi
wan9chi marked this pull request as ready for review September 21, 2026 10:50
@wan9chi
wan9chi merged commit 3aac49e into main Sep 21, 2026
19 checks passed
@wan9chi
wan9chi deleted the remote-cache-plan branch September 21, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant