Skip to content

Skip edition-enabled encodings with no registered plugin when writing - #9917

Merged
mhk197 merged 3 commits into
developfrom
mk/writer-registered-ids
Sep 16, 2026
Merged

mhk197 merged 3 commits into
developfrom
mk/writer-registered-ids

Conversation

@mhk197

@mhk197 mhk197 commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

#9914 stopped mapping the writer's permitted serialized IDs through the array registry before filtering compression schemes. That mapping had a side effect on the scheme filter only: an edition-enabled ID with no registered plugin produced None in the filter_map and was excluded from the set handed to the compressor. The array context never had that filter. It seeded and permitted every enabled ID whether or not a plugin was registered.

This PR filters at the source, so both the scheme set and the array context exclude enabled IDs that nothing on the session could serialize.

Changes

With editions enforced, new_array_context now keeps only the enabled array IDs that have a registered plugin. That set seeds the file's encoding table and, through to_ids, restricts the compressor. Without edition enforcement the set comes from the registry itself and needs no filter.

Behavior

Before #9914, a session that enabled an edition but did not register one of its encodings never selected that encoding's compression scheme. After #9914 the scheme could be selected, and the write then failed in array_serialize with "not registered for serialization". This PR returns to skipping the scheme.

Excluding those IDs from the array context is new behavior. An unregistered encoding can never be serialized, since array_serialize fails before any interning, so its entry in the file's encoding table was never used. The footer changes only for sessions in that partial-registry state. Every shipped writer registers all encodings, so none are affected.

Testing

A new test enables an edition listing vortex.primitive and vortex.alp on a bare array session, where ALP is not registered, and checks that only the primitive ID is seeded and ALP cannot be interned.

…iting

Signed-off-by: Matt Katz <mhkatz97@gmail.com>
@codspeed

codspeed Bot commented Sep 16, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 12.11%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 2199 untouched benchmarks
⏩ 218 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime arrow_checked_add_u32_neon[16384] 12.9 µs 20.3 µs -36.77%
WallTime mul_u32_nonnull_avx512 5.6 µs 6.3 µs -10.92%
Simulation allocate_drop_bytes[0] 635.5 ns 527.2 ns +20.55%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mk/writer-registered-ids (6fce0df) with develop (c11856c)

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@mhk197 mhk197 added the changelog/skip Do not list PR in the changelog label Sep 16, 2026
@mhk197
mhk197 marked this pull request as ready for review September 16, 2026 18:30
@mhk197
mhk197 requested a review from robert3005 September 16, 2026 18:32
Comment thread vortex-file/src/writer.rs Outdated
@mhk197
mhk197 requested a review from robert3005 September 16, 2026 18:35
@mhk197
mhk197 enabled auto-merge (squash) September 16, 2026 18:37
Comment thread vortex-file/src/writer.rs
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
@mhk197
mhk197 requested a review from robert3005 September 16, 2026 19:02
@mhk197
mhk197 merged commit f15c0b8 into develop Sep 16, 2026
98 of 99 checks passed
@mhk197
mhk197 deleted the mk/writer-registered-ids branch September 16, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants