Skip to content

refactor: store bitpacked chunk widths in a child #9939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mhk197 wants to merge 1 commit into from
Draft

refactor: store bitpacked chunk widths in a child #9939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion encodings/fastlanes/benches/bitpack_compare.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ fn page_aligned(array: BitPackedArray) -> BitPackedArray {
ptype,
parts.validity,
parts.patches,
parts.bit_width,
parts.widths,
parts.len,
parts.offset,
)
Expand Down
2 changes: 1 addition & 1 deletion encodings/fastlanes/benches/bitpack_compare_sweep.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ fn page_aligned(array: BitPackedArray) -> BitPackedArray {
ptype,
parts.validity,
parts.patches,
parts.bit_width,
parts.widths,
parts.len,
parts.offset,
)
Expand Down
6 changes: 4 additions & 2 deletions encodings/fastlanes/src/bitpacking/array/bitpack_compress.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ use vortex_mask::Mask;

use crate::BitPacked;
use crate::BitPackedArray;
use crate::ChunkWidths;
use crate::FL_CHUNK_SIZE;
use crate::bitpack_decompress;

pub fn bitpack_to_best_bit_width(
Expand Down Expand Up @@ -84,7 +86,7 @@ pub fn bitpack_encode(
array.ptype(),
array.validity()?,
patches,
bit_width,
ChunkWidths::uniform(bit_width, array.len().div_ceil(FL_CHUNK_SIZE)).into_array(),
array.len(),
0,
)?;
Expand Down Expand Up @@ -113,7 +115,7 @@ pub unsafe fn bitpack_encode_unchecked(
array.ptype(),
array.validity()?,
None,
bit_width,
ChunkWidths::uniform(bit_width, array.len().div_ceil(FL_CHUNK_SIZE)).into_array(),
array.len(),
0,
)
Expand Down
Loading
Loading