Skip to content

docs(repo): track reliability E6 prp (#387)#388

Merged
w7-mgfcode merged 2 commits into
devfrom
docs/reliability-e6-prp
Jun 12, 2026
Merged

docs(repo): track reliability E6 prp (#387)#388
w7-mgfcode merged 2 commits into
devfrom
docs/reliability-e6-prp

Conversation

@w7-mgfcode

@w7-mgfcode w7-mgfcode commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Tracks the reliability-E6 release-gate PRP (epic #387 of umbrella #380), following the E1–E5 precedent of committing each epic's PRP as docs(repo).

The gate itself was executed before this PR was opened — full evidence is on #387:

No app/, frontend/, or alembic/ change — PRP file only.

Refs #387, #380.

Summary by Sourcery

Documentation:

  • Document the reliability E6 release-gate plan, including end-to-end showcase_rich dogfood run, per-epic spot checks, validation gates, and umbrella issue close-out procedure.

@sourcery-ai

sourcery-ai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Adds a new PRP document that formalizes the reliability E6 release gate, describing how to verify the combined behavior of prior reliability epics (E1–E5), how to run the showcase_rich dogfood pipeline, which regression tests and spot checks to execute, and how to close out umbrella issue #380 and epic #387 without changing any application or frontend code.

Flow diagram for the reliability E6 release gate PRP

flowchart TD
  Start([Start E6 release gate])
  T0[Task 0: Preflight
- git dev clean
- no stale :8123
- record HEAD]
  T1[Task 1: Fresh stack
- docker compose down -v
- up -d
- alembic upgrade head
- backend & frontend up]
  T2[Task 2: showcase_rich dogfood
- LAN /showcase
- scenario=showcase_rich
- Re-seed first]
  CheckDogfood{Any ❌ step?}
  Stop[STOP RULE
- capture evidence
- open new fix issue
- comment on #387
- gate ends]
  T3_6[Tasks 3–6: E1–E5 spot checks
- E1 prefix 422
- E2 fallback 502
- E3 uuid utils
- E4 taxonomy imports
- E5 price-cut demand]
  CheckSpot{Any spot check fail?}
  T7[Task 7: Validation gates
- ruff check/format
- mypy
- pyright
- pytest not integration
- frontend uuid test]
  CheckGates{Any gate fail?}
  T8[Task 8: Evidence & close-out
- commit PRP
- evidence on #387
- tick & close #380
- close #387]
  End([Gate complete])

  Start --> T0 --> T1 --> T2 --> CheckDogfood
  CheckDogfood -->|Yes| Stop
  CheckDogfood -->|No| T3_6 --> CheckSpot
  CheckSpot -->|Yes| Stop
  CheckSpot -->|No| T7 --> CheckGates
  CheckGates -->|Yes| Stop
  CheckGates -->|No| T8 --> End
Loading

File-Level Changes

Change Details Files
Introduce a detailed PRP document defining the reliability E6 release gate process and success criteria.
  • Document the goal and success criteria for validating that reliability epics E1–E5 hold together as a single system on dev.
  • Specify the required dogfood run of the showcase_rich pipeline over a plain-HTTP LAN origin, including acceptable skips/warnings and evidence collection.
  • Describe per-epic spot checks for E1–E5, mapping each to concrete tests and optional live HTTP probes.
  • List the repository validation gates (ruff, mypy, pyright, pytest unit, frontend uuid-utils tests) that must pass for the gate to be considered green.
  • Provide a stepwise execution plan (tasks 0–9) covering environment setup, test execution, evidence capture, and GitHub issue close-out mechanics for fix(repo): platform reliability hardening — agents, config, ui, forecast #380 and fix(repo): reliability E6 — release gate (showcase_rich dogfood + umbrella close-out) #387.
  • Capture known environment gotchas, constraints (no code changes, stop rule, no fix-forward), and integration touchpoints with runtime services and GitHub.
PRPs/PRP-reliability-E6-release-gate.md

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a16740d0-a64d-4ac5-a0b0-035bf732fea7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/reliability-e6-prp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 2 issues

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="PRPs/PRP-reliability-E6-release-gate.md" line_range="3-5" />
<code_context>
+name: "PRP reliability-E6 — release gate: showcase_rich dogfood + per-epic spot checks + umbrella close-out"
+description: |
+  Issue #387 (epic E6 of umbrella #380, milestone reliability-hardening).
+  Release-gate epic: NO new production code. The deliverable is executed
+  verification — a green end-to-end showcase_rich dogfood run on a fresh stack,
+  one live spot check per closed reliability epic (E1 #334, E2 #335, E3 #332,
+  E4 #268, E5 #237), all five validation gates green on dev, evidence recorded
</code_context>
<issue_to_address>
**suggestion (typo):** Clarify the phrase 'The deliverable is executed verification' for grammatical correctness

This sentence reads ungrammatical. Please rephrase, e.g., to “The deliverable is an executed verification — a green …” or similar wording that makes the structure clearer.

```suggestion
  Issue #387 (epic E6 of umbrella #380, milestone reliability-hardening).
  Release-gate epic: NO new production code. The deliverable is an executed
  verification: a green end-to-end showcase_rich dogfood run on a fresh stack,
```
</issue_to_address>

### Comment 2
<location path="PRPs/PRP-reliability-E6-release-gate.md" line_range="445" />
<code_context>
+#     - verify ⏭️ — expected on a prophet_like (V2) winner: artifact roots differ
</code_context>
<issue_to_address>
**nitpick (typo):** Standardize spelling of 'artifact/artefact' for consistency

Here, we use both 'artifact' ("artifact roots differ") and 'artefacts' ("operator-visible artefacts are fine post-gate"). Please pick one spelling and apply it consistently across the document.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread PRPs/PRP-reliability-E6-release-gate.md Outdated
Comment on lines +3 to +5
Issue #387 (epic E6 of umbrella #380, milestone reliability-hardening).
Release-gate epic: NO new production code. The deliverable is executed
verification — a green end-to-end showcase_rich dogfood run on a fresh stack,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (typo): Clarify the phrase 'The deliverable is executed verification' for grammatical correctness

This sentence reads ungrammatical. Please rephrase, e.g., to “The deliverable is an executed verification — a green …” or similar wording that makes the structure clearer.

Suggested change
Issue #387 (epic E6 of umbrella #380, milestone reliability-hardening).
Release-gate epic: NO new production code. The deliverable is executed
verification a green end-to-end showcase_rich dogfood run on a fresh stack,
Issue #387 (epic E6 of umbrella #380, milestone reliability-hardening).
Release-gate epic: NO new production code. The deliverable is an executed
verification: a green end-to-end showcase_rich dogfood run on a fresh stack,

Comment thread PRPs/PRP-reliability-E6-release-gate.md Outdated

Task 9 — Teardown:
STOP the background uvicorn + vite processes started in Task 1.
LEAVE the seeded DB in place (operator-visible artefacts are fine post-gate).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (typo): Standardize spelling of 'artifact/artefact' for consistency

Here, we use both 'artifact' ("artifact roots differ") and 'artefacts' ("operator-visible artefacts are fine post-gate"). Please pick one spelling and apply it consistently across the document.

@w7-mgfcode w7-mgfcode merged commit 2c71928 into dev Jun 12, 2026
8 checks passed
@w7-mgfcode w7-mgfcode deleted the docs/reliability-e6-prp branch June 12, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant