Skip to content

feat(ui): showcase workspace full preset exposure (#391)#395

Merged
w7-mgfcode merged 4 commits into
devfrom
feat/showcase-preset-exposure
Jun 12, 2026
Merged

feat(ui): showcase workspace full preset exposure (#391)#395
w7-mgfcode merged 4 commits into
devfrom
feat/showcase-preset-exposure

Conversation

@w7-mgfcode

Copy link
Copy Markdown
Owner

Summary

Implements E2 — Full Preset Exposure (epic #391, umbrella #389, PRP PRPs/PRP-showcase-workspace-E2-preset-exposure.md).

  • Backend_SCENARIO_SEED_PROFILE extended from 3 to all 8 ScenarioPreset members via a _SeedProfile NamedTuple with an optional calendar-pinned window; step_seed honors the pinned window (holiday_rush2024-10-01..2024-12-31, since its HolidayConfig spikes are fixed 2024 dates). All windows ≥ 75 days (historical_backfill gate). sparsity=0.0 preserved so the sparse preset keeps its 50%-missing character (seeder override precedence).
  • FrontendScenarioPreset union widened to all 8 values (surgical CRLF-preserving edit); ScenarioPicker rewritten from a shadcn <Select> to an aria-pressed card grid (W3C APG button pattern, role="group"), props interface unchanged so showcase.tsx wiring is untouched. Caveat badges: sparse (expected fail/skip — NaN WAPE), holiday_rush (pinned 2024 window), showcase_rich (provider-key skips). Hint line: switching presets only takes effect with Re-seed first.
  • No phase-table change — the 5 newly exposed presets run the legacy 11-step flow (backend parametrized test + frontend it.each lockstep test enforce this).
  • DocsAPI_CONTRACTS.md documents the full 8-value union on POST /demo/run + the WS start frame; RUNBOOKS.md gains showcase entry feat(forecasting): implement baseline model zoo and unified interface #28 (per-preset expected-outcome matrix incl. the sparse NaN-WAPE trap and the re-seed accumulation behavior found during dogfood).

Validation

  • ruff check + ruff format --check clean
  • mypy app/ + pyright app/ (both --strict) — 0 errors
  • ✅ Backend unit suite: 1961 passed (incl. new profile-exhaustiveness, pinned-window POST-body, parametrized phase-table tests)
  • ✅ Demo slice integration: 10 passed against real Postgres
  • ✅ Frontend: pnpm lint (0 errors), pnpm test --run 331 passed (58 files); no NEW tsc -b errors in touched files (24 pre-existing on dev, unchanged)
  • ✅ Level-4 real-browser dogfood (Playwright + Chromium): 8 cards render with caveats, default demo_minimal aria-pressed; retail_standard re-seed run green (seed detail 5 stores x 15 products); holiday_rush reset+re-seed run green with /seeder/status exactly 2024-10-01..2024-12-31; demo_minimal restore green, today-anchored window confirmed

Closes #391

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @w7-mgfcode, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aa5a715c-5b1a-452b-b03c-d288ac8da5a1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/showcase-preset-exposure

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@w7-mgfcode w7-mgfcode merged commit 3194fe8 into dev Jun 12, 2026
8 checks passed
@w7-mgfcode w7-mgfcode deleted the feat/showcase-preset-exposure branch June 12, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant