-
-
Notifications
You must be signed in to change notification settings - Fork 679
Introduce beautify-lint and reformat files automatically #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5b93ce6
chore: Add beautify-lint as a part of lint-staged tasks chain
okonet 0adcddf
style: Fixed all styles accoring to the webpack's style
okonet 2781ca7
style: Beautify new files
okonet c453a90
style: More code style fixes
okonet 0caaa6c
style: Use (almost) the same eslint config as webpack does
okonet dd5e8ff
style: Run eslint --fix on all JS files
okonet d52ec35
style: Add missing "use strict"
okonet 17a79fb
build: Only run eslint on CI for now
okonet 22a802d
fixup! style: Add missing "use strict"
okonet 900d163
fixup! style: Add missing "use strict"
okonet a0239ca
fix: Use === instead of ==
okonet 93d8acc
style: Removed unused requires
okonet e27791d
style: Disable eslint valid-jsdoc rule in defineTest
okonet 241d026
Add additional .eslintrc to /bin to remove unrelated eslint errors
okonet 48b781a
Update beautify-lint glob pattern
okonet 293a12d
feat: Use prettier and eslint to style the code
DanielaValero 529c24d
feat: Set liting of quote-props as needed for integration with prettier
DanielaValero 87a5c49
build: Add jest-cli as dev dependency
DanielaValero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| module.exports = { | ||
| "root": true, | ||
| "plugins": ["node", "prettier"], | ||
| "extends": ["eslint:recommended", "plugin:node/recommended"], | ||
| "env": { | ||
| "node": true, | ||
| "es6": true, | ||
| "jest": true | ||
| }, | ||
| "parserOptions": { "ecmaVersion": 2017 }, | ||
| "rules": { | ||
| "quote-props": ["error", "as-needed"], | ||
| "no-dupe-keys": "error", | ||
| "quotes": ["error", "double"], | ||
| "no-undef": "error", | ||
| "no-extra-semi": "error", | ||
| "semi": "error", | ||
| "no-template-curly-in-string": "error", | ||
| "no-caller": "error", | ||
| "yoda": "error", | ||
| "eqeqeq": "error", | ||
| "global-require": "off", | ||
| "brace-style": "error", | ||
| "key-spacing": "error", | ||
| "space-in-parens": ["error", "never"], | ||
| "space-infix-ops": "error", | ||
| "indent": ["error", "tab", { "SwitchCase": 1 }], | ||
| "no-extra-bind": "warn", | ||
| "no-empty": "off", | ||
| "no-multiple-empty-lines": "error", | ||
| "no-multi-spaces": "error", | ||
| "no-process-exit": "off", | ||
| "no-trailing-spaces": "error", | ||
| "no-use-before-define": "off", | ||
| "no-unused-vars": ["error", { "args": "none" }], | ||
| "no-unsafe-negation": "error", | ||
| "no-loop-func": "warn", | ||
| "space-before-function-paren": ["error", "never"], | ||
| "space-before-blocks": "error", | ||
| "object-curly-spacing": ["error", "always"], | ||
| "keyword-spacing": ["error", { | ||
| "after": true, | ||
| "overrides": { | ||
| "const": { "after": true }, | ||
| "try": { "after": true }, | ||
| "catch": { "after": true }, | ||
| "if": { "after": true }, | ||
| "else": { "after": true }, | ||
| "throw": { "after": true }, | ||
| "case": { "after": true }, | ||
| "return": { "after": true }, | ||
| "finally": { "after": true }, | ||
| "do": { "after": true } | ||
| } | ||
| }], | ||
| "no-console": "off", | ||
| "valid-jsdoc": "error", | ||
| "node/no-unsupported-features": ["error", { "version": 4 }], | ||
| "node/no-deprecated-api": "error", | ||
| "node/no-missing-import": "error", | ||
| "node/no-missing-require": [ | ||
| "error", | ||
| { | ||
| "allowModules": [ | ||
| "webpack" | ||
| ] | ||
| } | ||
| ], | ||
| "node/no-unpublished-bin": "error", | ||
| "node/no-unpublished-require": "error", | ||
| "eol-last": ["error", "always"], | ||
| "newline-per-chained-call": "off", | ||
| "node/process-exit-as-throw": "error", | ||
| "prettier/prettier": ["error", { | ||
| "useTabs": true, | ||
| "bracketSpacing": false | ||
| }] | ||
| } | ||
| }; | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "rules": { | ||
| "node/no-missing-require": 0 | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for not including it? I believe it's much more readable with spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me double check, I was getting crazy errors of compatibility between eslint and prettify, did some tests, this might have squeezed in.