Skip to content

fix: 🐛 defaults flag behaviour#1323

Closed
anshumanv wants to merge 5 commits into
webpack:nextfrom
anshumanv:1322
Closed

fix: 🐛 defaults flag behaviour#1323
anshumanv wants to merge 5 commits into
webpack:nextfrom
anshumanv:1322

Conversation

@anshumanv

@anshumanv anshumanv commented Mar 14, 2020

Copy link
Copy Markdown
Contributor

Closes: #1322

What kind of change does this PR introduce?
Fix the application of default flags

Did you add tests for your changes?
Yes, enabled

If relevant, did you update the documentation?
Not needed

Summary

  • Fix the bug in the approach we use webpack-merge to apply default config.

Does this PR introduce a breaking change?
No.

Other information

@anshumanv
anshumanv requested a review from a team as a code owner March 14, 2020 18:56
@webpack-bot

Copy link
Copy Markdown

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@anshumanv anshumanv changed the title fix: 🐛 default flag behaviour fix: 🐛 defaults flag behaviour Mar 14, 2020
rishabh3112
rishabh3112 previously approved these changes Mar 15, 2020

@rishabh3112 rishabh3112 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

snitin315
snitin315 previously approved these changes Mar 15, 2020
himanshu010
himanshu010 previously approved these changes Mar 15, 2020
shivaylamba
shivaylamba previously approved these changes Mar 15, 2020
jamesgeorge007
jamesgeorge007 previously approved these changes Mar 15, 2020
@snitin315

Copy link
Copy Markdown
Member

@anshumanv can you resolve conflicts?

@anshumanv

Copy link
Copy Markdown
Contributor Author

Do we wish to support this @webpack/cli-team?

@alexander-akait

Copy link
Copy Markdown
Member

@anshumanv we need investigate what does this option do, most likely we will remove it

@anshumanv

anshumanv commented May 13, 2020

Copy link
Copy Markdown
Contributor Author

@anshumanv

Copy link
Copy Markdown
Contributor Author

Should we remove it then?

@alexander-akait

alexander-akait commented May 13, 2020

Copy link
Copy Markdown
Member

Yes, no need, let's remove, webpack already has good default values

@anshumanv

Copy link
Copy Markdown
Contributor Author

Okay, closing and removing in next PR. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

webpack-cli: wrong behavior of defaults flag

9 participants