feat(webpack-cli): add alias for version#1405
Merged
Merged
Conversation
alexander-akait
previously approved these changes
Apr 2, 2020
alexander-akait
previously approved these changes
Apr 2, 2020
anshumanv
reviewed
Apr 2, 2020
This comment has been minimized.
This comment has been minimized.
Member
|
@snitin315 Please open an issue about it |
snitin315
force-pushed
the
info
branch
3 times, most recently
from
April 3, 2020 13:45
02e7a70 to
e0275f2
Compare
Contributor
|
This should be handled after #1412 or maybe make your changes here and update tests accordingly. |
snitin315
changed the title
Member
Author
|
@anshumanv I have updated the PR for a standalone change and updated the test accordingly. I will tackle #1412 in a separate PR. |
alexander-akait
previously approved these changes
Apr 6, 2020
anshumanv
previously approved these changes
Apr 6, 2020
jamesgeorge007
previously approved these changes
Apr 6, 2020
Contributor
|
This seems to be in scope of #1347 |
Member
|
@jamesgeorge007 we can implement it here, and migrate on commander late |
Contributor
|
Sounds good 👍 |
snitin315
dismissed stale reviews from jamesgeorge007, anshumanv, and alexander-akait
via
April 6, 2020 11:50
100d74d
docs: add alias for version
anshumanv
approved these changes
Apr 6, 2020
alexander-akait
approved these changes
Apr 6, 2020
jamesgeorge007
approved these changes
Apr 6, 2020
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature. added alias for version.
Did you add tests for your changes?
YES
If relevant, did you update the documentation?
YES
Summary
Fixes #1368
Does this PR introduce a breaking change?
No
Other information
NA