tests: add tests for init#1419
Merged
Merged
Conversation
alexander-akait
requested changes
Apr 6, 2020
alexander-akait
left a comment
alexander-akait
left a comment
Member
There was a problem hiding this comment.
Need improve tests, good work
alexander-akait
requested changes
Apr 8, 2020
alexander-akait
left a comment
alexander-akait
left a comment
Member
There was a problem hiding this comment.
Move all tests under the __tests__ directory, avoid adding .gitignore
anshumanv
suggested changes
Apr 13, 2020
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: review-outdated
labels
wizardofhogwarts
previously approved these changes
Apr 15, 2020
alexander-akait
previously approved these changes
Apr 16, 2020
Member
|
/cc @webpack/cli-team |
rishabh3112
dismissed stale reviews from alexander-akait and wizardofhogwarts
via
April 16, 2020 14:22
e828dda
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-approved
PR: reviewed-changes-requested
labels
|
@rishabh3112 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @jamesgeorge007 Please review the new changes. |
alexander-akait
previously approved these changes
Apr 16, 2020
jamesgeorge007
approved these changes
Apr 16, 2020
Contributor
|
Thanks |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Tests for init package
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Not Applicable
Summary
Add tests for init package as part of roadmap.
Does this PR introduce a breaking change?
No
Other information
After this we would discuss more about the scaffold strategy and integrate it with CLI