fix: multiple config compilation error (rebase)#1468
Conversation
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
/cc @webpack/cli-team Should we accept bug fixes for |
|
Do we have an ETA for the merge |
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
/cc @webpack/cli-team
|
Also, can you please add a test case for |
|
@aman29271 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
|
@snitin315 Thanks for pointing out. Tests has been added. |
| expect(code).toBe(0); | ||
| expect(code).toBeDefined(); | ||
| expect(code).not.toBeNull(); | ||
| expect(summary).toEqual(expect.anything()); |
There was a problem hiding this comment.
Bad idea to do it, no need test on anything
|
Fixed in master, anyway big thanks for PR |
5 participants
What kind of change does this PR introduce?
A bugfix which closes #887
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Nope
Does this PR introduce a breaking change?
No
Other information