refactor(webpack-cli): remove --no-mode flag#1503
Merged
Merged
Conversation
alexander-akait
previously approved these changes
Apr 28, 2020
Member
|
/cc @Loonride |
knagaitsev
reviewed
Apr 29, 2020
snitin315
force-pushed
the
chore/no-mode
branch
from
April 29, 2020 06:13
6faaee9 to
3d2dc19
Compare
Signed-off-by: Nitin Kumar <snitin315@gmail.com>
snitin315
force-pushed
the
chore/no-mode
branch
from
April 29, 2020 06:20
3d2dc19 to
d7f1c9d
Compare
knagaitsev
approved these changes
Apr 29, 2020
Member
|
Thanks! |
snitin315
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Follow up #1481 .
remove
--no-mode.Did you add tests for your changes?
Removed
no-modetests.If relevant, did you update the documentation?
Yes
Summary
removed
--no-modebecause it is same as--mode noneand Negated flags makes more sense with boolean args.Does this PR introduce a breaking change?
Maybe
Other information