feat(init): add features and refactor#1590
Merged
Merged
Conversation
rishabh3112
marked this pull request as ready for review
May 30, 2020 08:48
alexander-akait
approved these changes
Jun 1, 2020
|
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
jamesgeorge007
approved these changes
Jun 1, 2020
anshumanv
approved these changes
Jun 1, 2020
snitin315
approved these changes
Jun 1, 2020
Member
|
@rishabh3112 @webpack/cli-team Sometimes CI failed, can you investigate? |
Contributor
Author
|
@evilebottnawi It occurs when even 100s timeout isn't enough some tests of |
Member
|
@rishabh3112 Let's move |
Member
|
@rishabh3112 Ready for merge? |
Contributor
Author
|
Yes |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature and refactors
Did you add tests for your changes?
Yes, WIP
If relevant, did you update the documentation?
No
Summary
Part of #1509
--forceflag to force config generation (in case of 0CJS as well).Does this PR introduce a breaking change?
No.
Other information
Work In Progress,