feat: add init to webpack-cli - #1609
Merged
Merged
Conversation
5 tasks
alexander-akait
left a comment
alexander-akait
left a comment
Member
There was a problem hiding this comment.
We need add test(s) to ensure we supported init command by default
Contributor
Author
|
Yes it is TODO as mentioned in PR description, will be working on it tonight. |
rishabh3112
marked this pull request as ready for review
June 4, 2020 17:47
evenstensberg
approved these changes
Jun 6, 2020
snitin315
approved these changes
Jun 7, 2020
alexander-akait
approved these changes
Jun 7, 2020
shivaylamba
approved these changes
Jun 8, 2020
jamesgeorge007
approved these changes
Jun 8, 2020
anshumanv
approved these changes
Jun 8, 2020
|
@rishabh3112 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @anshumanv Please review the new changes. |
Contributor
Author
|
Would be refactoring jest timeouts to make them consistent in a separate PR. |
This was referenced Sep 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Not applicable
Summary
Integrating
initpackage into CLI so that it is available by default.Does this PR introduce a breaking change?
No.
Other information
#1509