tests: for --optimization-mangle-exports & --optimization-used-exports#1729
Closed
snitin315 wants to merge 1 commit into
Closed
tests: for --optimization-mangle-exports & --optimization-used-exports#1729snitin315 wants to merge 1 commit into
snitin315 wants to merge 1 commit into
Conversation
alexander-akait
approved these changes
Aug 3, 2020
Contributor
|
@evilebottnawi do we need test with mangleExports in config as raised in #1677? If not we can close the config PR. |
Member
|
@anshumanv more tests are better |
Contributor
|
Okay, will keep it open, edited your comment @snitin315 |
shivaylamba
approved these changes
Aug 3, 2020
anshumanv
approved these changes
Aug 4, 2020
Member
|
Please regenerate lock file |
Contributor
|
Cant regenerate because we're on webpack latest, for next it's only generated while installing in CI. Hence when webpack releases with updated terser rerunning in all PRs will fix. /cc @snitin315 |
Member
|
@anshumanv Can you try to do it? |
Contributor
|
Closing in favour of #1732 |
Contributor
|
@snitin315 quick question, what's the approach you followed to trace this back? Just curious |
Member
Author
|
Theese flags or the terser warning? |
Contributor
|
terser warning |
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
tests, fix
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
NA
Summary
with the new release of webpack 5 new flags
--optimization-mangle-exports&--optimization-used-exportsare supported now. handling test cases for the same.Does this PR introduce a breaking change?
No
Other information