Skip to content

tests: remove --module-rules-options instances #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 2 commits into from
Aug 10, 2020
Merged

tests: remove --module-rules-options instances #1735

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
505b275
tests: remove --module-rules-options instances
snitin315 Aug 6, 2020
d6ae5a5
Merge branch 'next' into tests/module-rule-options
snitin315 Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/core-flags/module-flags.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

const { run, hyphenToUpperCase } = require('../utils/test-utils');
const { flagsFromCore } = require('../../packages/webpack-cli/lib/utils/cli-flags');
//--module-rules-options will be excluded for cli.
const moduleFlags = flagsFromCore.filter(({ name }) => name.startsWith('module-') && name !== 'module-rules-options');

const moduleFlags = flagsFromCore.filter(({ name }) => name.startsWith('module-'));

@alexander-akait alexander-akait Aug 10, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @snitin315 So we still don't have tests on module- flags?

@snitin315 snitin315 Aug 10, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evilebottnawi We have, This file contains exclusively tests for all module-* flags, We are extracting all the module-* flags here and then looping through them.

webpack-cli/test/core-flags/module-flags.test.js

Lines 8 to 9 in 4fe8045

describe('module config related flag', () => {
moduleFlags.forEach((flag) => {

@alexander-akait alexander-akait Aug 10, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarify!


describe('module config related flag', () => {
moduleFlags.forEach((flag) => {
Expand Down