Skip to content

tests: loader's tests for errors and warnings#1736

Merged
evenstensberg merged 4 commits into
nextfrom
tests/loader
Aug 19, 2020
Merged

tests: loader's tests for errors and warnings#1736
evenstensberg merged 4 commits into
nextfrom
tests/loader

Conversation

@snitin315

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?
test

Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Fixes #1581

Does this PR introduce a breaking change?
No

Other information

@snitin315
snitin315 requested a review from a team as a code owner August 6, 2020 11:00
Comment thread test/loader/error-test/loader-error.test.js Outdated
@alexander-akait

Copy link
Copy Markdown
Member

deprecations from ts-loader?

@snitin315

Copy link
Copy Markdown
Member Author

Yes, can we test on stdout only?

Comment thread test/loader/error-test/loader-error.test.js Outdated
@alexander-akait

Copy link
Copy Markdown
Member

Yes, let comment stderr (with comment on issue), open an issue in ts-loader and merge it

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need improve test

Comment thread test/loader/error-test/loader-error.test.js
@webpack-bot

Copy link
Copy Markdown

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evilebottnawi Please review the new changes.

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope it was fixed after removing execa

@snitin315

Copy link
Copy Markdown
Member Author

still same 😞

@alexander-akait

Copy link
Copy Markdown
Member

@snitin315 We need to solve it before release, there are two possible problems:

  • our test utils is not respect exit code
  • something wrong inside webpack-cli logic in try/catch

@alexander-akait

Copy link
Copy Markdown
Member

/cc @snitin315 Can we focus on it, because it is high priority for new release, we don't want break linter-loaders and other stuff what potential change exit code

@snitin315

Copy link
Copy Markdown
Member Author

Yes, I'm looking into it.

Comment thread packages/webpack-cli/lib/utils/Compiler.js
Comment thread packages/webpack-cli/lib/utils/Compiler.js

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note

Comment thread test/loader/warning-test/src/main.js
@snitin315 snitin315 changed the title tests: loader's error regression test for #1581 tests: loader's tests for errors and warnings Aug 19, 2020
@alexander-akait

Copy link
Copy Markdown
Member

/cc @webpack/cli-team we need fix it before release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

webpack-cli v4-beta.8 ignoring loader's error.

6 participants