Skip to content

feat: add support for merging multiple configurations#1768

Merged
alexander-akait merged 5 commits into
webpack:nextfrom
anshumanv:merge-flag
Aug 26, 2020
Merged

feat: add support for merging multiple configurations#1768
alexander-akait merged 5 commits into
webpack:nextfrom
anshumanv:merge-flag

Conversation

@anshumanv

@anshumanv anshumanv commented Aug 25, 2020

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

feat/fix

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
Yes

Summary

  • Merges all configurations together instead of single file
  • Merge flag is a boolean now
  • You can now do webpack -c 1.js -c 2.js -c 3.js --merge which was not possible before

Does this PR introduce a breaking change?
No

Other information
/cc @evilebottnawi

@anshumanv
anshumanv marked this pull request as ready for review August 26, 2020 05:54
@anshumanv
anshumanv requested a review from a team as a code owner August 26, 2020 05:54

@rishabh3112 rishabh3112 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Left a few suggestions.

Comment thread packages/webpack-cli/lib/utils/cli-flags.js Outdated
Comment thread packages/webpack-cli/lib/groups/ConfigGroup.js Outdated
Comment thread test/merge/config/merge-config.test.js
@anshumanv
anshumanv requested review from a team and rishabh3112 and removed request for rishabh3112 August 26, 2020 09:16
@anshumanv anshumanv changed the title feat: convert merge flag to boolean feat: add support for merging multiple configurations Aug 26, 2020
@webpack-bot

Copy link
Copy Markdown

@anshumanv Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evilebottnawi Please review the new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants