Skip to content

chore: remove lodash from direct dependencies#1834

Merged
rishabh3112 merged 4 commits into
nextfrom
chore/reduce-deps
Sep 25, 2020
Merged

chore: remove lodash from direct dependencies#1834
rishabh3112 merged 4 commits into
nextfrom
chore/reduce-deps

Conversation

@rishabh3112

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?
chore

Did you add tests for your changes?
No

If relevant, did you update the documentation?
No

Summary
Remove lodash from dependencies to reduce deps

Does this PR introduce a breaking change?
No

Other information
As per feedback for v4

@rishabh3112
rishabh3112 requested a review from a team as a code owner September 25, 2020 05:16

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabh3112 Do we remove lodash everywhere?

Comment thread yarn.lock
@rishabh3112

Copy link
Copy Markdown
Contributor Author

@rishabh3112 Do we remove lodash everywhere?

I have removed lodash where ever it was direct dep. Still many versions of lodash are shipped as transitive dep as mentioned by @anshumanv in his review as well.

@alexander-akait

Copy link
Copy Markdown
Member

Feel free to merge after green

@anshumanv

Copy link
Copy Markdown
Contributor

I have removed lodash where ever it was direct dep. Still many versions of lodash are shipped as transitive dep as mentioned by @anshumanv in his review as well.

We should remove version locking in packages, maybe that will reduce some

@anshumanv

anshumanv commented Sep 25, 2020

Copy link
Copy Markdown
Contributor

Will try to do it this weekend, or if anyone else wants to feel free and let me know

@alexander-akait

Copy link
Copy Markdown
Member

@anshumanv

We should remove version locking in packages, maybe that will reduce some

Where we have it?

@anshumanv

Copy link
Copy Markdown
Contributor

@evilebottnawi #958

@alexander-akait

Copy link
Copy Markdown
Member

@webpack/cli-team please focus on use ^ everywhere in package.json in the next PR, it is important

@rishabh3112
rishabh3112 merged commit 77ff99b into next Sep 25, 2020
@rishabh3112
rishabh3112 deleted the chore/reduce-deps branch September 25, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants