Skip to content

feat: bump CI Node to 14#1882

Merged
alexander-akait merged 2 commits into
webpack:nextfrom
anshumanv:build-node-14
Oct 7, 2020
Merged

feat: bump CI Node to 14#1882
alexander-akait merged 2 commits into
webpack:nextfrom
anshumanv:build-node-14

Conversation

@anshumanv

@anshumanv anshumanv commented Oct 6, 2020

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?
build

Did you add tests for your changes?
NA

If relevant, did you update the documentation?
NA

Summary

Trying running CI on Node 14

Does this PR introduce a breaking change?
No

Other information

@anshumanv

anshumanv commented Oct 6, 2020

Copy link
Copy Markdown
Contributor Author

Some tests failing on v14 @evilebottnawi need to be fixed

@alexander-akait

alexander-akait commented Oct 6, 2020

Copy link
Copy Markdown
Member

@anshumanv feel free to start working on this

@anshumanv

anshumanv commented Oct 6, 2020

Copy link
Copy Markdown
Contributor Author

@evilebottnawi issue in nodejs/node#32987 (comment) need update shelljs

alexander-akait
alexander-akait reviewed Oct 6, 2020
View reviewed changes

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do our users have warnings on Node@14 too?

alexander-akait
alexander-akait reviewed Oct 6, 2020
View reviewed changes

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to run yarn upgrade and send the fixed lock file?

@anshumanv

anshumanv commented Oct 6, 2020

Copy link
Copy Markdown
Contributor Author

Do our users have warnings on Node@14 too?

Yep seems to pop up from shelljs
image

@alexander-akait

alexander-akait commented Oct 6, 2020

Copy link
Copy Markdown
Member

0.8.4 fixed it, so we should just bump our deps in lock file

@anshumanv

anshumanv commented Oct 6, 2020

Copy link
Copy Markdown
Contributor Author

Yep already, #1731 need fix typescript build then 😞

@alexander-akait

alexander-akait commented Oct 6, 2020

Copy link
Copy Markdown
Member

It should be easy, we don't use many types

@anshumanv

anshumanv commented Oct 7, 2020

Copy link
Copy Markdown
Contributor Author

#1885 should fix it

@alexander-akait

alexander-akait commented Oct 7, 2020

Copy link
Copy Markdown
Member

/cc @anshumanv

@anshumanv

anshumanv commented Oct 7, 2020

Copy link
Copy Markdown
Contributor Author

Yep the error is gone, now just need fix CI with new warning messages in Node 14

@anshumanv
anshumanv marked this pull request as ready for review October 7, 2020 12:15
@anshumanv
anshumanv requested a review from a team as a code owner October 7, 2020 12:15
@anshumanv anshumanv changed the title [TEST CI] feat: bump CI Node to 14 feat: bump CI Node to 14 Oct 7, 2020
alexander-akait
alexander-akait approved these changes Oct 7, 2020
View reviewed changes

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

@alexander-akait
alexander-akait merged commit bdfd8f0 into webpack:next Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes
+1 more reviewer
@rishabh3112 rishabh3112 rishabh3112 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: reviewed-approved PR: small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anshumanv @alexander-akait @rishabh3112 @webpack-bot