[Feature] Open bot to the webpack-cli#224
Conversation
Added new dist command to generate a clean distribution folder
|
@ev1stensberg, @sokra New PR for the bot! Now it points to |
|
Notified Sokra about this, but the github hook comes up after checks succeed, so it is already integrated, yes? @sokra mind doing a quick review? This and one other issue left for a v2 RFC |
|
Let's take this for a spin LGTM |
* Added open-bot.yml configuration file for open bot, plus two npm scripts * Added open-bot.yml configuration file for open bot, plus two npm scripts * Updated open-bot configuration * Added new dist command Added new dist command to generate a clean distribution folder * Update travis configuration, runnable from the bot * Updated job from 'unit' to 'integration' * Moved to yarn and updated the matrix * Removed 'prepublish' * Fixed typo inside the configuration
| node_js: "8" | ||
| env: JOB_PART=integration | ||
| - os: linux | ||
| node_js: "7" |
There was a problem hiding this comment.
7 is a "in development" version number. Only even version numbers are node.js version you need to test.
There was a problem hiding this comment.
The the versions will be stable, 8 and 6? As far as I understood webpack 4 won't support v4 anymore.
Also, are the labels required for webpack-bot? I don't see it doing anything on new PRs.
4 participants
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Fixes #195
Does this PR introduce a breaking change?
No
Other information
The configuration is copied from
webpackrepository and adapted to the current repository. The actions that the bot will do are:CI-okandCI-not-okto the PRs (labels needed)PR: conflict(labels needed)unreviewed,reviewedandreview-outdatedto the PRs (labels needed)PR: smallif the PR contains small changes (label needed)I also added two new npm scripts that will be used just by the bot.