misc(grammar): revise spelling and incorrect syntax#293
Merged
Conversation
evenstensberg
approved these changes
Mar 1, 2018
evenstensberg
left a comment
evenstensberg
left a comment
Member
There was a problem hiding this comment.
Looks good here, thanks for the PR!
Member
|
You need to change your commit style as well as you might have broken some logic in the binTestCases as you renamed some files |
evenstensberg
changed the title
Contributor
Author
|
@ev1stensberg: I can't understand the builder's output... |
Member
|
okay so you need to rebase your commits like: |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Contributor
Author
|
@ev1stensberg: thanks, that worked |
evenstensberg
approved these changes
Mar 2, 2018
This was referenced Mar 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Spelling fixes
Did you add tests for your changes?
No. It's possible to write a test using
fchurn, but I'm not currently providing code for that in my PRs.Summary
Misspellings are embarrassing.
Does this PR introduce a breaking change?
runSingleTransformis a breaking change.I can provide a shim if required.
Other information
Generated by https://github.com/jsoref/spelling
f; to maintain your repo, please considerfchurn