Skip to content

fix: removes debug in migrate#342

Merged
evenstensberg merged 1 commit into
webpack:masterfrom
anu-007:rem-debug
Mar 14, 2018
Merged

fix: removes debug in migrate#342
evenstensberg merged 1 commit into
webpack:masterfrom
anu-007:rem-debug

Conversation

@anu-007

@anu-007 anu-007 commented Mar 13, 2018

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?
bugfix - removes debug in migrate.

Did you add tests for your changes?
No
If relevant, did you update the documentation?
n/a
Summary
Fixes 120 : removes debug after running migrate on a config that has debug

Does this PR introduce a breaking change?

No
Other information
n/a

@jsf-clabot

jsf-clabot commented Mar 13, 2018

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@dhruvdutt dhruvdutt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use commitlint for linting commit messages. Use git cz for an interactive commit or use one of these.

@webpack-bot

Copy link
Copy Markdown

@anu-007 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@dhruvdutt Please review the new changes.

@webpack-bot

Copy link
Copy Markdown

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

devtool: 'eval',
entry: [
devtool: 'eval',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please keep the 'no space' between the two lines, please? I guess this wasn't intentional :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, unless jest did it?!

@montogeek montogeek Mar 13, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a file generated by Jest, __snapshots__ folder

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why we run prettier on the config after we've written @ematipico . j.literal and j.identifier causes this, no bug.

@evenstensberg

Copy link
Copy Markdown
Member

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Debug in migrate doesn't remove the property as expected

7 participants