Skip to content

chore(ci): fix build#534

Merged
ematipico merged 1 commit into
webpack:nextfrom
dhruvdutt:next
Jun 29, 2018
Merged

chore(ci): fix build#534
ematipico merged 1 commit into
webpack:nextfrom
dhruvdutt:next

Conversation

@dhruvdutt

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary

  • Update pretest scripts to include TS compilation
  • Fixes all CI build errors

Does this PR introduce a breaking change?

Other information

@webpack-bot

Copy link
Copy Markdown

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@dhruvdutt

Copy link
Copy Markdown
Contributor Author

From Codacy:

Seems like the next is not being analyzed. To review this pull request enable the branch in the project settings.

@evenstensberg evenstensberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ematipico
ematipico merged commit 9db4842 into webpack:next Jun 29, 2018
dhruvdutt added a commit to dhruvdutt/webpack-cli that referenced this pull request Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants