chore(build): fix ci#535
Merged
Merged
Conversation
Contributor
Author
|
Needs investigation. |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Member
|
What's the status on this? |
Contributor
Author
Tests are breaking because of some change in yargs 12. |
evenstensberg
approved these changes
Jul 4, 2018
evenstensberg
left a comment
evenstensberg
left a comment
Member
There was a problem hiding this comment.
looks lgtm here, is this ready?
dhruvdutt
commented
Jul 4, 2018
dhruvdutt
left a comment
dhruvdutt
left a comment
Contributor
Author
There was a problem hiding this comment.
I hope the changes in stdin looks good. The order of output has changed a little bit as now it's adding a line in between outputting the entrypoint file name.
Looks good to merge if the change in output order is acceptable.
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Fixed some linting issue but the tests are still failing due to some other issue (currently debugging)
Does this PR introduce a breaking change?
Other information