tests(migration): typescript

[dhruvdutt]

What kind of change does this PR introduce?
Tests: Refactoring to TypeScript

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
NA

Summary
Added ts-test branch on upstream. We will keep working on this branch to migrate all tests to TypeScript.

Does this PR introduce a breaking change?
No

Other information
cc @sendilkumarn @ematipico

Packages that contains tests to port to typescript

• add
• generate-loader
• generate-plugin
• generators
• info
• init
• make
• migrate
• remove
• serve
• update
• utils
• webpack-scaffold: tests(webpack-scaffold): move to typescript #686 by @hemal7735

[ematipico]

Started the migration of other files. Please follow the same pattern

[rishabh3112]

Can I help in this migration too?
If so can I get pointers from where to get started 😅

[ematipico]

Hi @rishabh3112, surely you can!
We are migrating the tests inside the different packages from JavaScript to TypeScript.

There's a task list that I added inside the main issue with the different packages and we are going to tick the ones that are migrated.

Please feel free to pick one and tell us, so we are going to update the main thread and we are not going to work on the same thing.

Most of them don't require an actual tests because they are just wrappers (add, update, etc.).

The main bulk will be utils package. So I'd suggest to take your time with one/two tests files and start the migration.

Please use the ts-test branch to commit your changes.

• tests must be moved inside a __tests__ folder.
• __fixtures__ will be moved inside the __tests__ folder
• the javascript files inside the fixtures must stay as JavaScript file. They don't need to be ported because they are the real configuration that will be processed by our AST parser, hence TS is not a valid syntax

[rishabh3112]

Thanks @ematipico 🙌,
I will look into this and let everyone know on which package I would be working.
(Sorry for late reply though 😅)

[rishabh3112]

I am facing a little difficulty in setting up.
How can I keep intact my npm installation intact while working over repo?
@ematipico, @dhruvdutt, @ev1stensberg?

[evenstensberg]

I think this PR should be on hold until the new test infrastructure is up

[dhruvdutt]

Since the new infra is now ready, we can start working on this. Every contribution is welcomed. We will continue working on ts-test branch.

@rishabh3112 Not sure why GitHub isn't allowing me to assign you. 😅

[evenstensberg]

Needs rebase

[misterdev]

@dhruvdutt @evenstensberg I've worked on the pending requested changes and made a PR, would be great to have any kind of feedback 👍

[dhruvdutt]

Working on rebasing this.

[evenstensberg]

Status?

[webpack-bot]

@sendilkumarn Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ematipico Please review the new changes.

[sendilkumarn]

I merged upstream changes. Hopefully, this one will be good to go 🤞

[webpack-bot]

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

[evenstensberg]

could we remove this?

[sendilkumarn]

makes sense 👍

[evenstensberg]

As a final check, could you pull master branch, check if we are missing something?

[sendilkumarn]

This has latest master in it. so we can merge

[sendilkumarn]

@evenstensberg Let us not wait further. I will merge this. I think on the Typescript side it is better to follow some conventions like utilizing type inferences and being strict on any (things like that). I will create a new PR out of this.