[WIP] init endpoint of ui-server#685
Conversation
…not working due to issue with s
|
|
| const cookieParser = require("cookie-parser"); | ||
| const logger = require("morgan"); | ||
| const indexRouter = require("./routes/index"); | ||
| const apiRouter = require("./routes/api"); |
There was a problem hiding this comment.
Redundant import
| const apiRouter = require("./routes/api"); |
| res.json({ title: "Express" }); | ||
| }); | ||
|
|
||
| router.use(require('./api')); |
There was a problem hiding this comment.
use /api as the base route for the server calls.
We would be using /api/init for json calls to render /init and same for other endpoints.
| router.use(require('./api')); | |
| router.use('/api',require('./api')); |
|
Sign CLA too |
|
@LakshSingla Thanks for your update. I labeled the Pull Request so reviewers will review it again. @rishabh3112 Please review the new changes. |
|
@rishabh3112 Thanks for the suggestions. I have made the required changes. But I am still stuck on how to call the actual |
|
I think we should refactor and change interface of This way debugging in future would be better.Let have others viewpoint. |
|
@rishabh3112 I was thinking the same thing, to provide an alternative way of programmatically passing in the parameters for |
|
@rishabh3112 Should I start with the refactoring? Also what all needs to be refactored? I would begin with the |
|
Yes, inquirier logic and generator logic have to be separated in order to achieve this PR. The server will just pass an object to the generator, which will create the webpack file for us. The object will contain the same set of answers. Because of the fact that we are using typescript, I think there could be an interface that design the object answers that we can pass to the generator. If there isn't, we should create it. I think to make things easier, using typescript for the server might be a better fit because of the typings... |
|
@ematipico Should I open a seperate issue regarding this issue? Also, I suppose that the generator logic to be moved and inquirer logic stay in place at |
|
I think better would be that every generator exports:
and also a function that would return a multi-dimensional array having questions. Then for passing Object we can: import { ui } from "@webpack-cli/init"
...
let input: Object; // or we may have a interface here instead of object
// taking input from server
ui(input);
...Review approch @ematipico I would do necessary updations then. Also, @evenstensberg didn't gave review for design as he said to me he will be. If you have suggestions you may let me know. After that I would design other pages as well. |
|
@rishabh3112 Thanks for help with the PR! As soon as you are done with the necessary refactoring, lemme know so that I can make the required changes. |
|
@rishabh3112 Any updates in refactoring ?? |
|
I am having my end semester exams till the end of this month. |
|
No worries |
|
|
||
| const port = process.env.PORT || 8000; | ||
|
|
||
| console.log(port); |
|
|
||
| console.log(port); | ||
|
|
||
| app(path.join('..', '..', 'static')).listen(port, () => { |
| console.log(port); | ||
|
|
||
| app(path.join('..', '..', 'static')).listen(port, () => { | ||
| console.log(`server started on 127.0.0.1:${port}`); |
|
@LakshSingla I guess it would be better to open a separate issue |
|
hey @rishabh3112 any update on this PR ? |
|
Just to understand this correctly, this one can be close as @rishabh3112 continue the work at #756 right? |
|
Could you rebase this? |
|
As per meetings, we're decided that UI should be third party |
|
Thank you so much for taking the time to create this Pull Request, you've helped shape the way we're going with webpack(cli) ❤️ |
7 participants
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Created the route for
POST: initfor default scaffold. Does not work as expected due to issues instdinof the child process spawned.#649
Does this PR introduce a breaking change?
No
Other information
None