Skip to content

feat: use webpack.config as default name in dev scaffold#753

Merged
evenstensberg merged 1 commit into
masterfrom
enh/default-config-name
Mar 8, 2019
Merged

feat: use webpack.config as default name in dev scaffold#753
evenstensberg merged 1 commit into
masterfrom
enh/default-config-name

Conversation

@evenstensberg

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

Fixes #707
Did you add tests for your changes?
Ya
If relevant, did you update the documentation?
N/A
Summary
Changes default name of config in scaffolding

Does this PR introduce a breaking change?
N/a

Other information

@anshumanv anshumanv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick fix ✨

@webpack-bot

Copy link
Copy Markdown

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@evenstensberg
evenstensberg merged commit 9e13b40 into master Mar 8, 2019
@evenstensberg
evenstensberg deleted the enh/default-config-name branch March 8, 2019 21:56
@anshumanv

anshumanv commented Mar 25, 2019

Copy link
Copy Markdown
Contributor

Can I send a quick PR to rename the prod config to webpack.production.js as explained in the issue or is there a different approach? 🤔

@evenstensberg

@evenstensberg

Copy link
Copy Markdown
Member Author

let's go for prod and dev

@anshumanv

Copy link
Copy Markdown
Contributor

The issue outlines to go for production and development do we drop that?

@evenstensberg

Copy link
Copy Markdown
Member Author

I don’t think it did. @TheLarkInn is that true or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enh: Name of webpack config should default to webpack.config.js

3 participants