Skip to content

fix(add): add handling for topScope #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evenstensberg merged 4 commits into from
Mar 19, 2019
Merged

fix(add): add handling for topScope #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1162cf5
fix(add): add handling for topScope
rishabh3112 Mar 18, 2019
163b309
fix(add): lint code
rishabh3112 Mar 18, 2019
dbc3e9e
fix(add): fix runTransform
rishabh3112 Mar 19, 2019
d4ce6f2
fix(add): add types
rishabh3112 Mar 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/generators/add-generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,19 @@ export default class AddGenerator extends Generator {
this.configuration.config.webpackOptions.entry = entryOptions;
this.configuration.config.item = action;
});
}
} else {
if (action === "topScope") {
return this.prompt([
Input("topScope", "What do you want to add to topScope?"),
])
.then((topScopeAnswer: {
topScope: string;
}) => {
this.configuration.config.topScope.push(topScopeAnswer.topScope);
done();
});
}
}
const temp: string = action;
if (action === "resolveLoader") {
action = "resolve";
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/scaffold.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export default function runTransform(transformConfig: ITransformConfig, action:

const transformations: string[] = mapOptionsToTransform(config);

if (config.topScope) {
if (config.topScope && transformations.indexOf("topScope") === -1) {
transformations.push("topScope");
}

Expand Down