chore(cli): move constants to a separate file#798
Merged
Conversation
moved all constants to a separate file for CLI scopre and imported from there. ISSUES CLOSED: webpack#772
Format all code using prettier, remove console.log ISSUES CLOSED: webpack#772
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
codacy fix
rishabh3112
suggested changes
Mar 21, 2019
rishabh3112
left a comment
rishabh3112
left a comment
Contributor
There was a problem hiding this comment.
This refactor is shining 💯
Few suggestions for you.
split constants destructuring to multiple lines in config-yargs
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
Contributor
Author
|
@rishabh3112 done with the quick fixes. 💯 |
ematipico
suggested changes
Mar 21, 2019
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: review-outdated
labels
update var name, revert oc
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
moved constants to utils directory
ematipico
approved these changes
Mar 22, 2019
rishabh3112
approved these changes
Mar 22, 2019
misterdev
reviewed
Mar 22, 2019
| const OPTIMIZE_GROUP = "Optimizing options:"; | ||
| const DISPLAY_GROUP = "Stats options:"; | ||
| const GROUPS = { | ||
| CONFIG_GROUP, |
Contributor
There was a problem hiding this comment.
Wouldn't be more compact to initialize the constants inside the JSON? :)
const GROUPS = {
CONFIG_GROUP: "Config options:"
Contributor
There was a problem hiding this comment.
What do you mean by "compact"?
dhruvdutt
approved these changes
Mar 23, 2019
anshumanv
added a commit
to anshumanv/webpack-cli
that referenced
this pull request
Mar 26, 2019
* chore(cli): move constants to a separate file moved all constants to a separate file for CLI scopre and imported from there. ISSUES CLOSED: webpack#772 * chore(cli): lint files, rm console.log Format all code using prettier, remove console.log ISSUES CLOSED: webpack#772 * chore(cli): codacy fix codacy fix * chore(cli): split destructuring into multiple lines split constants destructuring to multiple lines in config-yargs * chore(cli): update var name, revert oc update var name, revert oc * chore(cli): moved constants to utils moved constants to utils directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor constants
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Not relevant
Summary
Does this PR introduce a breaking change?
No
Other information
Fixes #772