chore: fix and refactor add generator by rishabh3112 · Pull Request #843 · webpack/webpack-cli

rishabh3112 · 2019-04-21T03:35:38Z

What kind of change does this PR introduce?

refactoring

Did you add tests for your changes?
No

If relevant, did you update the documentation?
N/A

Summary
Updating prompting() to use async/await

Does this PR introduce a breaking change?

Maybe

Other information
#836

pranshuchittora

IMO this might affect node 6.x users.

Node supports async/await out of the box since version 7.6.

rishabh3112 · 2019-04-21T10:35:56Z

Refer #836

pranshuchittora · 2019-04-21T10:38:24Z

@rishabh3112 👍

rishabh3112 · 2019-04-22T14:22:37Z

Ready for a review now 👍

evenstensberg

I'll do some manual testing while I got time, but nice work.

evenstensberg · 2019-04-22T20:22:07Z

+			}
+		}
+
+		const temp: string = action;


reassigning a const

Where? temp is never reassigned anywhere and here it is declared.

ematipico

Left some feedback!

rishabh3112 · 2019-04-23T13:24:49Z

Thanks for review @ematipico
I will look into it and resolve these in this PR.

P.S
Just for clearing things 😅,
All of the code, in which you requested changes, was there as it is before this PR and not written by me originally.

ematipico · 2019-04-23T13:48:15Z

Oh yeah don't worry! We know it's working all right, if you think it doesn't require any change and it will steal too much time of yours, mark it as resolved and move along. :)

rishabh3112 · 2019-04-23T14:17:52Z

Well all are done and it didn't steal my time :). Pushing commits after a quick test.

webpack-bot · 2019-05-05T14:35:42Z

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

rishabh3112 · 2019-05-05T14:38:49Z

Done @evenstensberg

rishabh3112 · 2019-05-19T02:32:42Z

@webpack/cli-team can I have a review on this PR, this is fine IMO

rishabh3112 · 2019-05-24T14:58:47Z

cc @evenstensberg

anshumanv

Seems good to go!

rishabh3112 · 2019-05-27T17:29:26Z

@evenstensberg PTAL 😅

evenstensberg · 2019-05-28T05:28:22Z

Thanks, will get back to you this week. Quite a big PR and need to manually test

evenstensberg

Triaging #817 first to avoid complication of work

evenstensberg · 2019-05-30T17:33:59Z

@rishabh3112 could you rebase and let's continue on getting this merged once you're done?

rishabh3112 · 2019-05-30T17:39:30Z

Sure, will catch you tommorow. It's night here now and I am sleeping :)

evenstensberg · 2019-05-30T17:40:50Z

Gotcha, sleep tight!

webpack-bot · 2019-05-31T08:06:38Z

@rishabh3112 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@anshumanv Please review the new changes.

evenstensberg · 2019-06-07T12:10:16Z

Could you rebase?

rishabh3112 · 2019-06-07T16:29:04Z

Will do it @evenstensberg, but is it required now?, as add package is being removed Or we would keep generators and remove packages only?

evenstensberg · 2019-06-07T17:53:37Z

Nah I don't think it's worth

chore(async): update prompting

b5e5db0

webpack-bot added PR: conflict PR: unreviewed labels Apr 21, 2019

chore(async): async/await all questions

9214b5c

rishabh3112 changed the title ~~chore(async): add generator to async/await~~ [WIP] chore(async): add generator to async/await Apr 21, 2019

rishabh3112 marked this pull request as ready for review April 21, 2019 04:39

chore(async): merge master

b54bbca

webpack-bot added PR: CI-not-ok and removed PR: conflict labels Apr 21, 2019

chore(async): lint code

e0003c9

webpack-bot added PR: CI-ok and removed PR: CI-not-ok labels Apr 21, 2019

pranshuchittora reviewed Apr 21, 2019

View reviewed changes

anshumanv mentioned this pull request Apr 22, 2019

[Discussion] Recommend using async/await for prompting #836

Closed

8 tasks

chore(async): update tsconfig

1327b56

rishabh3112 changed the title ~~[WIP] chore(async): add generator to async/await~~ chore(async): add generator to async/await Apr 22, 2019

evenstensberg reviewed Apr 22, 2019

View reviewed changes

ematipico suggested changes Apr 23, 2019

View reviewed changes

Comment thread packages/generators/add-generator.ts Outdated

Comment thread packages/generators/add-generator.ts Outdated

Comment thread packages/generators/add-generator.ts Outdated

Comment thread packages/generators/add-generator.ts

Comment thread packages/generators/add-generator.ts Outdated

webpack-bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Apr 23, 2019

rishabh3112 added 3 commits April 23, 2019 19:18

chore(refactor): interface for schema property

d5d6f13

chore(refactor): use as boolean

1420ac4

chore(refactor): remove object assign

f5e6834

chore(refactor): update variable name

a35847e

webpack-bot added the PR: CI-not-ok label May 5, 2019

chore(types): update types and lint

fa0aea7

webpack-bot added PR: CI-ok and removed PR: CI-not-ok labels May 5, 2019

rishabh3112 mentioned this pull request May 24, 2019

chore(add-generator): changed the naming of the plugin in config file #893

Merged

anshumanv approved these changes May 24, 2019

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels May 24, 2019

evenstensberg reviewed May 28, 2019

View reviewed changes

chore: update with merge

ed2a7d9

webpack-bot added PR: review-outdated and removed PR: reviewed-approved labels May 31, 2019

evenstensberg reviewed May 31, 2019

View reviewed changes

Comment thread tsconfig.json Outdated

chore: update tsconfig

bf5511c

evenstensberg added the Up for Manual Verification label Jun 1, 2019

rishabh3112 mentioned this pull request Jun 3, 2019

fix(add): add handling of merge option #797

Merged

evenstensberg closed this Jun 7, 2019

Uh oh!

Uh oh!

Conversation

rishabh3112 commented Apr 21, 2019

Uh oh!

pranshuchittora left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rishabh3112 commented Apr 21, 2019

Uh oh!

pranshuchittora commented Apr 21, 2019

Uh oh!

rishabh3112 commented Apr 22, 2019

Uh oh!

evenstensberg left a comment

Choose a reason for hiding this comment

Uh oh!

evenstensberg Apr 22, 2019

Choose a reason for hiding this comment

Uh oh!

rishabh3112 Apr 23, 2019

Choose a reason for hiding this comment

Uh oh!

ematipico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rishabh3112 commented Apr 23, 2019

Uh oh!

ematipico commented Apr 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rishabh3112 commented Apr 23, 2019

Uh oh!

webpack-bot commented May 5, 2019

Uh oh!

rishabh3112 commented May 5, 2019

Uh oh!

rishabh3112 commented May 19, 2019

Uh oh!

rishabh3112 commented May 24, 2019

Uh oh!

anshumanv left a comment

Choose a reason for hiding this comment

Uh oh!

rishabh3112 commented May 27, 2019

Uh oh!

evenstensberg commented May 28, 2019

Uh oh!

evenstensberg left a comment

Choose a reason for hiding this comment

Uh oh!

evenstensberg commented May 30, 2019

Uh oh!

rishabh3112 commented May 30, 2019

Uh oh!

evenstensberg commented May 30, 2019

Uh oh!

webpack-bot commented May 31, 2019

Uh oh!

Uh oh!

evenstensberg commented Jun 7, 2019

Uh oh!

rishabh3112 commented Jun 7, 2019

Uh oh!

evenstensberg commented Jun 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pranshuchittora left a comment •

edited

Loading

ematipico commented Apr 23, 2019 •

edited

Loading