chore: addon generator to async/await#849
Merged
Merged
Conversation
addon-generator to async/await
rm comments
ematipico
suggested changes
Apr 22, 2019
ematipico
left a comment
ematipico
left a comment
Contributor
There was a problem hiding this comment.
The return type is wrong
addon gen rm type
|
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
webpack-bot
added
PR: review-outdated
PR: CI-ok
and removed
PR: reviewed-changes-requested
PR: CI-not-ok
labels
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ematipico
suggested changes
Apr 22, 2019
ematipico
left a comment
ematipico
left a comment
Contributor
There was a problem hiding this comment.
Please set the returning type
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: review-outdated
labels
8 tasks
add return type
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
ematipico
approved these changes
Apr 22, 2019
evenstensberg
approved these changes
Apr 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
NA
Summary
Does this PR introduce a breaking change?
No
Other information
Not yet