fix(init): fixes config resolution on generating new configuration#977
Merged
Conversation
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
pranshuchittora
force-pushed
the
init-fix
branch
from
June 28, 2019 07:54
2cf7d96 to
0d6fe14
Compare
evenstensberg
requested changes
Jul 30, 2019
evenstensberg
left a comment
Member
There was a problem hiding this comment.
Could you rebase against next ?
Contributor
Author
Sure |
pranshuchittora
force-pushed
the
init-fix
branch
from
July 30, 2019 20:44
139b75f to
72bb694
Compare
|
@pranshuchittora Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evenstensberg Please review the new changes. |
pranshuchittora
force-pushed
the
init-fix
branch
from
July 30, 2019 20:49
72bb694 to
44fa20c
Compare
Contributor
Author
|
Prettier config in the next branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes entry point issues in the newly generated webpack config
Closes #976
What kind of change does this PR introduce?
Bugfix
Did you add tests for your changes?
Nopes
If relevant, did you update the documentation?
Nopes
Summary
While generating new config I am surprised that the generated webpack.config.js doesn't have an entry point.