Skip to content

fix(init): fixes config resolution on generating new configuration#977

Merged
evenstensberg merged 1 commit into
webpack:nextfrom
pranshuchittora:init-fix
Aug 14, 2019
Merged

fix(init): fixes config resolution on generating new configuration#977
evenstensberg merged 1 commit into
webpack:nextfrom
pranshuchittora:init-fix

Conversation

@pranshuchittora

Copy link
Copy Markdown
Contributor

fixes entry point issues in the newly generated webpack config
Closes #976

What kind of change does this PR introduce?
Bugfix

Did you add tests for your changes?
Nopes
If relevant, did you update the documentation?
Nopes
Summary
While generating new config I am surprised that the generated webpack.config.js doesn't have an entry point.

@webpack-bot

Copy link
Copy Markdown

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@evenstensberg evenstensberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase against next ?

@pranshuchittora

Copy link
Copy Markdown
Contributor Author

Could you rebase against next ?

Sure

@webpack-bot

Copy link
Copy Markdown

@pranshuchittora Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evenstensberg Please review the new changes.

@pranshuchittora
pranshuchittora changed the base branch from master to next July 30, 2019 20:49
@pranshuchittora

Copy link
Copy Markdown
Contributor Author

Prettier config in the next branch.

   1   │ {
   2   │     "singleQuote": true,
   3   │     "trailingComma": "all"
   4   │ }

@evenstensberg evenstensberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞[init]: entry point does not appears in newly generated config

3 participants