fix: use correct port for https reverse proxy

[qswinson]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

New test cases have been added

Motivation / Use-Case

This solves #4292 where the port of the webpack dev server is used instead of the port from the location in https situations.

Breaking Changes

no breaking changes

Additional Info

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Quenby Mitchell (23dc6f4)

[alexander-akait]

It is breaking change and breaks URLs for local development

[qswinson]

It is breaking change and breaks URLs for local development

Can you provide a test case for the test suite that you say is breaking so I can address it? All of the unit tests are passing. The current behavior is a breaking change from Webpack v4 and is preventing us from upgrading.

[alexander-akait]

Because you fix it only for 0.0.0.0/etc, it is not valid fix, also other developers can use different ports for proxy, we don't know your proxied port and can't rely on location port (even more it is security problem), you can set https://webpack.js.org/configuration/dev-server/#websocketurl, in your case you can set port: 0, it will be auto -

webpack-dev-server/client-src/utils/createSocketURL.js

Line 143 in 23dc6f4

socketURLPort = self.location.port;

, i.e. what you want