ML-DSA Composite Signature Support by stenslae · Pull Request #1109 · wolfSSL/wolfssh

stenslae · 2026-07-16T21:45:45Z

Introduced support for ML-DSA composite signatures for hybrid post-quantum authentication.

Added ML-DSA44-Ed25519 as per draft-miller-sshm-mldsa44-ed25519-composite-sigs
Added ML-DSA44-ECDSA-P256, ML-DSA65-ED25519, ML-DSA65-ECDSA-P256, ML-DSA87-ED448, ML-DSA87-ECDSA-P384 as per draft-sun-ssh-composite-sigs-02

Added all sig types as auth options into the test echoservers, new CI tests, and interop tested mldsa44-ed25519 wtih openssh-portable.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #1109

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #1109

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #1109

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #1109

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #1109

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #1109

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #1109

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

JacobBarthelmeh · 2026-08-10T16:11:49Z

@stenslae please see the wolfSSL-Fenrir-bot comments and close them out. (can be marked resolved if they are false positives / bad). Then re-assign to wolfSSL-bot when ready for final review / merge.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #1109

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #1109

Scan targets checked: wolfssh-bugs, wolfssh-src

No new issues found in the changed files. ✅

stenslae requested a review from wolfSSL-Fenrir-bot July 16, 2026 21:45

stenslae self-assigned this Jul 16, 2026

wolfSSL-Fenrir-bot reviewed Jul 16, 2026

View reviewed changes

Comment thread src/internal.c

Comment thread examples/echoserver/echoserver.c

stenslae commented Jul 17, 2026

View reviewed changes

Comment thread src/internal.c

stenslae commented Jul 17, 2026

View reviewed changes

Comment thread examples/echoserver/echoserver.c

stenslae force-pushed the ml-dsa-hybrid-support-rebased branch 2 times, most recently from 9753775 to b1fec5b Compare July 20, 2026 16:46

stenslae requested a review from wolfSSL-Fenrir-bot July 20, 2026 16:46

stenslae force-pushed the ml-dsa-hybrid-support-rebased branch from b1fec5b to 5af710c Compare July 20, 2026 16:50

stenslae marked this pull request as ready for review July 20, 2026 16:53

wolfSSL-Fenrir-bot reviewed Jul 20, 2026

View reviewed changes

Comment thread examples/echoserver/echoserver.c

Comment thread examples/echoserver/echoserver.c

stenslae commented Jul 20, 2026

View reviewed changes

Comment thread examples/echoserver/echoserver.c

stenslae commented Jul 20, 2026

View reviewed changes

Comment thread examples/echoserver/echoserver.c

stenslae force-pushed the ml-dsa-hybrid-support-rebased branch from 5af710c to 1050ef1 Compare July 20, 2026 20:45

stenslae requested a review from wolfSSL-Fenrir-bot July 20, 2026 20:45

stenslae force-pushed the ml-dsa-hybrid-support-rebased branch from 1050ef1 to a1fddf0 Compare July 20, 2026 21:52

stenslae requested review from wolfSSL-Fenrir-bot and removed request for wolfSSL-Fenrir-bot July 20, 2026 22:29

wolfSSL-Fenrir-bot reviewed Jul 20, 2026

View reviewed changes

Comment thread wolfssh/internal.h Outdated

stenslae commented Jul 21, 2026

View reviewed changes

Comment thread wolfssh/internal.h Outdated

stenslae force-pushed the ml-dsa-hybrid-support-rebased branch from a1fddf0 to 2137136 Compare July 21, 2026 17:51

stenslae requested a review from wolfSSL-Fenrir-bot July 21, 2026 17:52

stenslae force-pushed the ml-dsa-hybrid-support-rebased branch from 2137136 to 145e2cf Compare July 21, 2026 18:15

wolfSSL-Fenrir-bot reviewed Jul 21, 2026

View reviewed changes

Comment thread src/internal.c Outdated

stenslae force-pushed the ml-dsa-hybrid-support-rebased branch from 145e2cf to 7228798 Compare July 21, 2026 18:23

stenslae commented Jul 21, 2026

View reviewed changes

Comment thread src/internal.c Outdated

stenslae force-pushed the ml-dsa-hybrid-support-rebased branch from 7228798 to 47dd078 Compare July 21, 2026 18:24

stenslae requested a review from wolfSSL-Fenrir-bot July 21, 2026 18:25

wolfSSL-Fenrir-bot reviewed Jul 21, 2026

View reviewed changes

Comment thread src/internal.c

Comment thread src/internal.c

stenslae commented Jul 21, 2026

View reviewed changes

Comment thread src/internal.c

stenslae commented Aug 6, 2026

View reviewed changes

Comment thread apps/wolfsshd/test/test_configuration.c

stenslae commented Aug 6, 2026

View reviewed changes

Comment thread tests/unit.c

stenslae commented Aug 6, 2026

View reviewed changes

Comment thread src/internal.c

stenslae force-pushed the ml-dsa-hybrid-support-rebased branch from ec83417 to c820ef1 Compare August 6, 2026 22:30

stenslae requested a review from wolfSSL-Fenrir-bot August 6, 2026 22:30

wolfSSL-Fenrir-bot reviewed Aug 6, 2026

View reviewed changes

Comment thread src/internal.c

Comment thread src/keygen.c Outdated

stenslae commented Aug 7, 2026

View reviewed changes

Comment thread src/internal.c

stenslae commented Aug 7, 2026

View reviewed changes

Comment thread src/keygen.c Outdated

Add ML-DSA44-Ed25519 composite signature support

23599fc

stenslae force-pushed the ml-dsa-hybrid-support-rebased branch from c820ef1 to 840e927 Compare August 7, 2026 21:55

stenslae requested a review from wolfSSL-Fenrir-bot August 7, 2026 21:56

wolfSSL-Fenrir-bot reviewed Aug 7, 2026

View reviewed changes

Comment thread apps/wolfsshd/test/test_configuration.c

Comment thread apps/wolfsshd/test/test_configuration.c Outdated

Comment thread apps/wolfsshd/test/test_configuration.c

Comment thread apps/wolfsshd/auth.c

JacobBarthelmeh assigned stenslae and unassigned wolfSSL-Bot Aug 10, 2026

stenslae commented Aug 10, 2026

View reviewed changes

Comment thread apps/wolfsshd/test/test_configuration.c

stenslae commented Aug 10, 2026

View reviewed changes

Comment thread apps/wolfsshd/test/test_configuration.c

stenslae commented Aug 10, 2026

View reviewed changes

Comment thread apps/wolfsshd/auth.c

stenslae commented Aug 10, 2026

View reviewed changes

Comment thread apps/wolfsshd/test/test_configuration.c Outdated

stenslae force-pushed the ml-dsa-hybrid-support-rebased branch from 840e927 to 9b0c290 Compare August 10, 2026 17:17

stenslae requested a review from wolfSSL-Fenrir-bot August 10, 2026 17:17

wolfSSL-Fenrir-bot reviewed Aug 10, 2026

View reviewed changes

Comment thread apps/wolfsshd/wolfsshd.c

Comment thread src/internal.c

stenslae commented Aug 10, 2026

View reviewed changes

Comment thread apps/wolfsshd/wolfsshd.c

stenslae commented Aug 10, 2026

View reviewed changes

Comment thread src/internal.c

Add remaining ML-DSA composite signature algorithms

39cf432

stenslae force-pushed the ml-dsa-hybrid-support-rebased branch from 9b0c290 to 39cf432 Compare August 10, 2026 17:56

stenslae requested a review from wolfSSL-Fenrir-bot August 10, 2026 17:56

wolfSSL-Fenrir-bot reviewed Aug 10, 2026

View reviewed changes

stenslae assigned ejohnstown Aug 10, 2026

ejohnstown approved these changes Aug 10, 2026

View reviewed changes

Uh oh!

Conversation

stenslae commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #1109

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #1109

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #1109

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #1109

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #1109

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #1109

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #1109

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JacobBarthelmeh commented Aug 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #1109

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #1109

Uh oh!

Reviewers

Assignees

Labels

stenslae commented Jul 16, 2026 •

edited

Loading