feat(user-management): add max_age parameter to getAuthorizationUrl#1643
Conversation
| connectionId, | ||
| domainHint, | ||
| loginHint, | ||
| maxAge, | ||
| organizationId, | ||
| provider, | ||
| providerQueryParams, |
There was a problem hiding this comment.
🚩 claimNonce is not forwarded in getAuthorizationUrlWithPKCE
The getAuthorizationUrlWithPKCE method does not destructure or forward claimNonce to the query string (user-management.ts:1514-1527), unlike getAuthorizationUrl which includes claim_nonce: claimNonce at line 1460. This is a pre-existing omission not introduced by this PR, but since this PR is adding a new field (maxAge) to both methods, it's worth noting for consistency. A user passing claimNonce to getAuthorizationUrlWithPKCE would have it silently ignored.
(Refers to lines 1514-1527)
Was this helpful? React with 👍 or 👎 to provide feedback.
Greptile SummaryThis PR adds the OIDC
Confidence Score: 5/5Safe to merge — the change is additive and isolated to URL generation; no existing behaviour is altered. The change is a small, additive parameter threaded through two related methods that already follow this exact pattern. The toQueryString utility only skips undefined, so the maxAge?.toString() idiom is correct and max_age=0 works as expected. No auth logic, token handling, or existing flows are modified. No files require special attention. Important Files Changed
|
e1c838a to
2a89c42
Compare
Support the OIDC `max_age` parameter in userManagement.getAuthorizationUrl and getAuthorizationUrlWithPKCE, serialized to the `max_age` query param.
8efea68 to
a54a886
Compare
Description
Adds support for the OIDC
max_ageparameter touserManagement.getAuthorizationUrlanduserManagement.getAuthorizationUrlWithPKCE.max_agespecifies the maximum allowable elapsed time (in seconds) since the user last actively authenticated. If the user's last authentication is older than this value, they will be prompted to re-authenticate.Documentation
Yes, this requires documentation changes.