Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
* [#690](https://github.com/workos/workos-python/pull/690) fix(generated): regenerate from spec

**Features**
* **[audit_logs](https://workos.com/docs/reference/audit-logs)**:
* Added `expired` to `AuditLogExportState`
2 changes: 1 addition & 1 deletion .last-synced-sha
Original file line number Diff line number Diff line change
@@ -1 +1 @@
23faa38318d596e581656934ed72c4a18476d742
56a015eaa3c5fb42a7dd77526c43953a971f4907
8 changes: 8 additions & 0 deletions .oagen-manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -2092,6 +2092,14 @@
"PUT /user_management/users/{user_id}/connected_accounts/{slug}": {
"sdkMethod": "update_user_connected_account",
"service": "pipes"
},
"GET /user_management/radar_challenges/{id}": {
"sdkMethod": "get_radar_challenge",
"service": "user_management"
},
"DELETE /user_management/redirect_uris/{id}": {
"sdkMethod": "delete_redirect_uris",
"service": "user_management"
}
}
}
1 change: 0 additions & 1 deletion src/workos/common/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@
from .models import (
DataIntegrationCredentialsResponseError as DataIntegrationCredentialsResponseError,
)
from .models import DataIntegrationCredentialsType as DataIntegrationCredentialsType
from .models import DataIntegrationCredentialType as DataIntegrationCredentialType
from .models import (
DataIntegrationCustomProviderAuthenticateVia as DataIntegrationCustomProviderAuthenticateVia,
Expand Down
4 changes: 1 addition & 3 deletions src/workos/common/models/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,7 @@
from .custom_provider_definition_authenticate_via import (
CustomProviderDefinitionAuthenticateVia as CustomProviderDefinitionAuthenticateVia,
)
from .data_integration_credentials_type import * # noqa: F401,F403
from .data_integration_access_token_response_error import (
DataIntegrationAccessTokenResponseError as DataIntegrationAccessTokenResponseError,
)
Expand All @@ -300,9 +301,6 @@
from .data_integration_credentials_response_error import (
DataIntegrationCredentialsResponseError as DataIntegrationCredentialsResponseError,
)
from .data_integration_credentials_type import (
DataIntegrationCredentialsType as DataIntegrationCredentialsType,
)
from .data_integration_credential_type import (
DataIntegrationCredentialType as DataIntegrationCredentialType,
)
Expand Down
6 changes: 2 additions & 4 deletions src/workos/pipes/models/__init__.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
# This file is auto-generated by oagen. Do not edit.

from .connected_account import * # noqa: F401,F403
from .connected_account_dto import * # noqa: F401,F403
from workos.common.models.connected_account import ConnectedAccount as ConnectedAccount
from .connected_account_dto import ConnectedAccountDto as ConnectedAccountDto
from .create_data_integration import CreateDataIntegration as CreateDataIntegration
from .custom_provider_definition import (
CustomProviderDefinition as CustomProviderDefinition,
)
from .data_integration_credentials_dto import * # noqa: F401,F403
from .data_integration import DataIntegration as DataIntegration
from .data_integration_access_token_response import (
DataIntegrationAccessTokenResponse as DataIntegrationAccessTokenResponse,
Comment on lines 2 to 13

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Wildcard imports from files without __all__ pollute module namespace

connected_account_dto.py and data_integration_credentials_dto.py do not define __all__, so from .connected_account_dto import * and from .data_integration_credentials_dto import * will export every public name in those files — including Enum, datetime, dataclass, Any, Dict, List, Optional, ConnectedAccountState, and DataIntegrationCredentialsType — into workos.pipes.models. Any downstream from workos.pipes.models import * would then unexpectedly pick up these typing/stdlib names. Adding __all__ = ["ConnectedAccountDto"] (and similarly for the DTO) to the source files would scope the export correctly, matching the approach already used by data_integration_credentials_type.py.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/workos/pipes/models/__init__.py
Line: 2-13

Comment:
**Wildcard imports from files without `__all__` pollute module namespace**

`connected_account_dto.py` and `data_integration_credentials_dto.py` do not define `__all__`, so `from .connected_account_dto import *` and `from .data_integration_credentials_dto import *` will export every public name in those files — including `Enum`, `datetime`, `dataclass`, `Any`, `Dict`, `List`, `Optional`, `ConnectedAccountState`, and `DataIntegrationCredentialsType` — into `workos.pipes.models`. Any downstream `from workos.pipes.models import *` would then unexpectedly pick up these typing/stdlib names. Adding `__all__ = ["ConnectedAccountDto"]` (and similarly for the DTO) to the source files would scope the export correctly, matching the approach already used by `data_integration_credentials_type.py`.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Expand All @@ -20,9 +21,6 @@
from .data_integration_credential import (
DataIntegrationCredential as DataIntegrationCredential,
)
from .data_integration_credentials_dto import (
DataIntegrationCredentialsDto as DataIntegrationCredentialsDto,
)
from .data_integration_credentials_response import (
DataIntegrationCredentialsResponse as DataIntegrationCredentialsResponse,
)
Expand Down
2 changes: 1 addition & 1 deletion src/workos/sso/models/__init__.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# This file is auto-generated by oagen. Do not edit.

from .connection import Connection as Connection
from .connection_option import * # noqa: F401,F403

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Wildcard import without __all__ leaks stdlib names into workos.sso.models

connection_option.py has no __all__, so from .connection_option import * exports ConnectionOption plus dataclass, Any, Dict, and Optional into the workos.sso.models namespace. Defining __all__ = ["ConnectionOption"] in connection_option.py would match the contained pattern already used by data_integration_credentials_type.py and avoid unexpected names appearing in the public interface.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/workos/sso/models/__init__.py
Line: 4

Comment:
**Wildcard import without `__all__` leaks stdlib names into `workos.sso.models`**

`connection_option.py` has no `__all__`, so `from .connection_option import *` exports `ConnectionOption` plus `dataclass`, `Any`, `Dict`, and `Optional` into the `workos.sso.models` namespace. Defining `__all__ = ["ConnectionOption"]` in `connection_option.py` would match the contained pattern already used by `data_integration_credentials_type.py` and avoid unexpected names appearing in the public interface.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

from .connection_domain import ConnectionDomain as ConnectionDomain
from .connection_option import ConnectionOption as ConnectionOption
from .connections_connection_type import (
ConnectionsConnectionType as ConnectionsConnectionType,
)
Expand Down