Treat older plugin no-update versions as up to date#535
Merged
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
schlessera
force-pushed
the
fix/5320-ignore-older-no-update
branch
from
July 23, 2026 09:01
55638a1 to
6af207a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
schlessera
marked this pull request as ready for review
July 23, 2026 09:44
swissspidy
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
WordPress separates plugin update data into
response(an update is available) andno_update(the plugin was checked, but no update is available).WP-CLI additionally compared the installed plugin version with
new_versionfor entries inno_update. When the installed version was higher, it changed the status toversion higher than expected.wp plugin updatethen treated the plugin as skipped and could return an error even though WordPress considered it up to date.This is observable with third-party update providers. The latest report in wp-cli/wp-cli#5320 points to Kadence Blocks 3.7.6 and its Harbor-backed legacy license update flow. Harbor may place an older or empty catalog version in
no_update; both values trigger WP-CLI's special case. The execution context cannot resolve this because the transient has already been populated.Solution
Keep the normal
nonestatus for plugin entries inno_updatewhen their upstream version is older or empty. This matches WordPress Core, which only considers entries inresponseupdateable.This does not restore the old false-positive "Updated" result: items with
update: noneare excluded before the upgrader runs. The existing handling for a newer version inno_updateremains unchanged, as that represents an unavailable update due to requirements or missing package access.Tests
new_version.none, and both bulk and single-plugin updates return the normal "already updated" success.Fixes wp-cli/wp-cli#5320
Summary by CodeRabbit