fix: detect closed WordPress.org plugins - #550
Conversation
|
Hello! 👋 Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project. Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation. Here are some useful Composer commands to get you started:
To run a single Behat test, you can use the following command: # Run all tests in a single file
composer behat features/some-feature.feature
# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123You can find a list of all available Behat steps in our handbook. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe WordPress.org plugin fixture now uses valid JSON. ChangesClosed plugin status
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change correctly reports closed plugins while preserving requested last-updated data and API fallback behavior. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Fixes WordPress.org closed-plugin detection while preserving Trac-based update lookups.
Changes:
- Detects
error: "closed"andclosed: trueresponses. - Corrects the closed-plugin fixture JSON.
- Preserves
wporg_last_updatedhandling.
File summaries
| File | Description |
|---|---|
src/Plugin_Command.php |
Detects closed plugin API responses. |
features/plugin-list-wporg-status.feature |
Uses valid JSON and verifies closed status. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
error: "closed"orclosed: true.wporg_last_updatedis requested.Fixes #549
Tests
vendor/bin/behat features/plugin-list-wporg-status.featurecomposer lintcomposer lint-gherkinSummary by CodeRabbit