ignore unused parameter 'buf' warning - #283
Merged
tdegeus merged 3 commits intoMar 10, 2023
Merged
Conversation
Contributor
Author
|
Not sure, but the appveyor fail seems to be unrelated to my pull request? |
Member
|
Thanks! You could also just remove the name |
Contributor
Author
|
I don't understand the code well enough to propose such a change. To me this looks like a dummy function (just just returns true) to implement a sort of interface (but I don't know which one). That said: If you have a better understanding of the code-base and you say that we can remove the argument, it is of cause not problem for me to adapt the PR :-) |
tdegeus
requested changes
Mar 9, 2023
Co-authored-by: Tom de Geus <tdegeus@users.noreply.github.com>
Member
|
Tanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I included <xtensor-python/xtensor_type_caster_base.hpp> into my code to let pybind11 automatically convert xtensor xarrays to numpy arrays.
However I get two "-wunused-parameter warnings" which seem to be straightforward to fix :-)