iOS TOTP OSS 仕様準拠の確認#1
Closed
NMai-source wants to merge 11 commits into
Closed
Conversation
15 tasks
ykws
reviewed
Oct 14, 2021
| @@ -0,0 +1,8 @@ | |||
| // | |||
ykws
reviewed
Oct 14, 2021
| PODFILE CHECKSUM: 07904d67eb13b9136ed0ec5bcece3229fe2f25a7 | ||
|
|
||
| COCOAPODS: 1.10.2 | ||
| COCOAPODS: 1.11.0 |
Owner
ykws
reviewed
Oct 14, 2021
Owner
There was a problem hiding this comment.
コミット 56dae2b の Author がそれまでと変わっていました。
- 該当するコミット :
Author: 中神舞 <nakagamimai@nakagamimainoMacBook-puro.local> - それまでのコミット:
Author: Nakagami Mai <nm30.mmn0kg@gmail.com>
おそらく PC を変えた影響だと思うのですが、
git config で user.name, user.email を設定してください。
Owner
|
@NMai-source バッジの意図についてはこちらを参考にして付けています
|
Owner
|
@NMai-source 作成が後手に回ってしまったのですが、以下の Pull Request Template に合わせて説明欄の変更をお願いします。 |
Owner
|
@NMai-source #3 設定画面の追加までをこの Pull Request とできるように branch を分けてもらえますか? アルゴリズムの選択などは #2 の Issue 対応として、この Pull Request とは別で作成してください。 |
Owner
|
@NMai-source main に CI を導入したのでこの Pull Request に main を merge or rebase してみてください。 コミットがきれいになるので rebase がおすすめです。 手順の例
コマンドの例 |
Owner
|
#10 と重複するのでこちらは閉じます。 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
設定画面の追加