設定画面のテキストを全て表示する対応#12
Merged
Merged
Conversation
ykws
requested changes
Oct 30, 2021
2648133 to
6e35f4e
Compare
Collaborator
Author
|
branchを作り直しました。 |
6e35f4e to
33ffe00
Compare
Owner
|
@NMai-source 赤枠のコミットだけがこの課題の変更に該当すると思うので、この PR のコミットはこれだけになっているのが望ましいです。 今回のケースだと、一例ですが、 cherry-pick を利用すると実現しやすそうです。 参考 |
Collaborator
Author
|
@ykws |
33ffe00 to
3e6cc79
Compare
Collaborator
Author
|
@ykws |
ykws
requested changes
Nov 3, 2021
| <rect key="frame" x="30" y="11" width="170" height="20"/> | ||
| <constraints> | ||
| <constraint firstAttribute="width" constant="170" id="J4w-Qf-Jlq"/> | ||
| <constraint firstAttribute="width" relation="lessThanOrEqual" constant="170" id="fvy-zA-QbD"/> |
Owner
ykws
approved these changes
Nov 11, 2021
Owner
ykws
left a comment
There was a problem hiding this comment.
全て表示できるようになっていることを確認できました!
スクリーンショットも見やすくて良いです!
最新の main を rebase してこの PR をマージしてみてください。
Owner
6a20f81 to
cc353a6
Compare
Collaborator
Author
|
@ykws |
Owner
|
@NMai-source ばっちりです! GitHub 上でマージできるようになっているのでそのままマージして大丈夫です! |
Collaborator
Author
|
@ykws |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





対応内容
設定画面のテキストを全て表示する対応
トークン表示画面のテキスト表示調節対応
スクリーンショット
Closes #9