Conversation
d-v-b
approved these changes
Sep 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4381 +/- ##
=======================================
Coverage 94.22% 94.22%
=======================================
Files 92 92
Lines 12942 12942
=======================================
Hits 12195 12195
Misses 747 747
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #3622.
A single-byte element has no internal byte ordering, so
<u1,>u1and|u1can describe the same uint8 data. Currently only|u1is registeredas a UInt8 v2 name: the stored bytes are valid, but metadata parsing rejects
the two aliases and prevents the array from opening.
This accepts both aliases while keeping
|u1as the serialized name.For reviewers
The implementation extends only the accepted UInt8 v2 names.
<u1and>u1are accepted on input, while serialization remains
|u1. Tests cover dtypeand registry parsing, reading local arrays containing
[0, 128, 255],canonical serialization, unchanged on-disk metadata after read-only access,
and rejection of invalid names and object codecs. Other dtypes and v3 are unchanged.
Local validation run by Codex on Windows with Python 3.12.2:
tests/test_store/test_local.py, reproduced on main in the same environment.mypy --platform linuxpasses for 196 files; this is type analysis, not a Linux runtime test.Codex implemented the code, tests and changelog, ran the local checks, and
translated and polished my explanation, and prepared the validation notes. A separate Codex agent performed a static review.
I have reviewed and understand the changes.
Author attestation
TODO
docs/user-guide/*.md— bug fix; changelog addedchanges/