fix: relation fields are included even if they are set false in select clause

[ymc9]

Fixes #1427

[coderabbitai]

Walkthrough

Walkthrough

The recent updates involve enhancements in the policy utility class to optimize query processing, correction of a typo in an error message within the expression validator, and the introduction of a regression test to address a discrepancy in data querying with relation fields. These changes aim to refine functionality and ensure consistency in data handling across different components of the software.

Changes

File Path	Change Summary
.../runtime/src/enhancements/policy/policy-utils.ts	Added condition to skip processing if injectTarget[field] is false.
.../schema/src/language-server/validator/expression-validator.ts	Corrected typo in error message regarding unresolved auth() function.
tests/regression/tests/issue-1427.test.ts	Introduced a test case for issue #1427, focusing on a regression scenario involving data manipulation.

Assessment against linked issues

Objective	Addressed	Explanation
Exclude fields with false or undefined values in query results (Issue #1427)	❓	The changes suggest an approach to skip processing, but it's unclear if this directly resolves the issue as described. Further inspection of how injectTarget[field] is used in queries is needed.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cb50826 and a90435d.

Files selected for processing (3)

• packages/runtime/src/enhancements/policy/policy-utils.ts (1 hunks)
• packages/schema/src/language-server/validator/expression-validator.ts (1 hunks)
• tests/regression/tests/issue-1427.test.ts (1 hunks)

Files not reviewed due to errors (1)

• packages/runtime/src/enhancements/policy/policy-utils.ts (no review received)

Files skipped from review due to trivial changes (1)

• packages/schema/src/language-server/validator/expression-validator.ts

Additional comments not posted (1)

tests/regression/tests/issue-1427.test.ts (1)

3-42: The test case is well-structured and effectively tests the exclusion of fields set to false in the select clause, as described in the PR objectives.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a90435d and d8c499e.

Files selected for processing (1)

• packages/schema/tests/schema/validation/attribute-validation.test.ts (1 hunks)

Files skipped from review due to trivial changes (1)

• packages/schema/tests/schema/validation/attribute-validation.test.ts