fix: Validation error when @@unique attribute is defined in the different model of the relation field

[jiashengguo]

No description provided.

[coderabbitai]

Walkthrough

Walkthrough

The recent updates involve enhancing the DataModelValidator by adding a condition to differentiate and validate unique fields based on the model context. Additionally, the error messages have been improved to include model names, making them more informative. New test models A and B have also been introduced to verify these validations effectively, ensuring the integrity of one-to-one relationships through unique constraints.

Changes

File Path	Summary of Changes
.../src/language-server/validator/datamodel-validator.ts	Added conditional check for unique fields based on model context; updated error messages to include model names.
.../tests/schema/validation/datamodel-validation.test.ts	Introduced new models A and B with defined fields and relationships; updated error messages in tests to specify the model name in relation to unique field constraints.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6a71742 and 3491413.

Files selected for processing (2)

• packages/schema/src/language-server/validator/datamodel-validator.ts (2 hunks)
• packages/schema/tests/schema/validation/datamodel-validation.test.ts (2 hunks)

Additional comments not posted (2)

packages/schema/src/language-server/validator/datamodel-validator.ts (1)

Line range hint 364-380: Ensure proper handling of unique constraints in inherited models.

Verification successful

---

The verification process has confirmed that the getUniqueFields function is indeed utilized within the DataModelValidator class to handle unique constraints, particularly in scenarios involving inherited models. This function is imported from utils.ts and used in datamodel-validator.ts to gather unique fields from both the containingModel and contextModel, which aligns with the intended logic described in the review comment.

Here are the specific usages identified:

• The function is defined in packages/schema/src/language-server/utils.ts.
• It is imported and used in packages/schema/src/language-server/validator/datamodel-validator.ts to get unique fields from models, supporting the validation logic for unique constraints in inherited models.

This confirms that the implementation handles unique constraints as expected when models are inherited.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that the unique constraints are properly handled when models are inherited.

# Test: Search for the usage of `getUniqueFields` function. Expect: Proper handling of unique constraints in inherited models.
rg --type typescript $'getUniqueFields'

Length of output: 73

---

---

Script:

#!/bin/bash
# Description: Verify that the unique constraints are properly handled when models are inherited.

# Test: Search for the usage of `getUniqueFields` function. Expect: Proper handling of unique constraints in inherited models.
rg --type ts 'getUniqueFields'

Length of output: 520

packages/schema/tests/schema/validation/datamodel-validation.test.ts (1)

524-524: Update error message to include model context for clarity.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3491413 and c2fd041.

Files selected for processing (2)

• packages/schema/src/language-server/validator/datamodel-validator.ts (2 hunks)
• packages/schema/tests/schema/validation/datamodel-validation.test.ts (2 hunks)

Files skipped from review as they are similar to previous changes (2)

• packages/schema/src/language-server/validator/datamodel-validator.ts
• packages/schema/tests/schema/validation/datamodel-validation.test.ts