Skip to content

FT0Calibration: changing TFs per slot with respect to 32 HBFs - #11228

Merged
martenole merged 1 commit into
AliceO2Group:devfrom
afurs:dev_ft0_calib
Apr 28, 2023
Merged

FT0Calibration: changing TFs per slot with respect to 32 HBFs#11228
martenole merged 1 commit into
AliceO2Group:devfrom
afurs:dev_ft0_calib

Conversation

@afurs

@afurs afurs commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@afurs
afurs requested a review from a team as a code owner April 25, 2023 12:19
@chiarazampolli

Copy link
Copy Markdown
Collaborator

@afurs

afurs commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator Author

Hello @chiarazampolli yes, please. Or I can change it later.

@chiarazampolli

Copy link
Copy Markdown
Collaborator

Please, change it in O2DPG.
Consider also changing it in a more universal way, in number of orbits or seconds, to not depend on the TF length.

@afurs

afurs commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator Author

Okay, thanks!

@afurs

afurs commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator Author

Hello @chiarazampolli I changed it in standalone, or do you mean var preparation which will be used here? if it is possible, could you please merge it asap, because right now we have 5/4 min slot length which is too short for our calibration :)

@chiarazampolli

Copy link
Copy Markdown
Collaborator

Hello @afurs ,

i meant to change it such that it is in number of orbits or seconds, so that it does not depend on the TF length in orbits (if it gets changed), see mail somr time ago to wp13.

pinging @shahor02 , @davidrohr to merge, i cannot.

chiara

@afurs

afurs commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator Author

@chiarazampolli ok, I see

@martenole

Copy link
Copy Markdown
Contributor

I can merge as it is now, but it would indeed be good if we could get rid of hard-coded numbers that depend on the TF length. See README here: https://github.com/AliceO2Group/AliceO2/tree/dev/Detectors/Calibration#configuration-of-the-timeslot
And for example here it is used

mCalibrator->setSlotLengthInSeconds(slotL);

@martenole
martenole merged commit 1b70887 into AliceO2Group:dev Apr 28, 2023
@afurs
afurs deleted the dev_ft0_calib branch May 5, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants