FT0Calib: changing number of TF per slot for standalone calibration - #1034
Merged
Conversation
afurs
requested review from
chiarazampolli,
davidrohr,
martenole and
shahor02
as code owners
April 26, 2023 08:38
Contributor
|
Is there a corresponding PR in O2 which should go in parallel with this change? |
Contributor
Author
|
Hi, I guess this one AliceO2Group/AliceO2#11228 |
Collaborator
|
Aren't they completely independent? I don't know when the DATA/production/calib/ft0-timeoffset-aggregator.sh changed here is used, but there is no software change needed to approve it. |
Contributor
|
Ah right, this is a standalone calibration and the change in O2 if for normal physics runs, correct? In that case this can of course simply be merged |
Contributor
Author
|
@martenole yes, in O2 part I already changed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.